Bug 248693 - [PATCH][asmc] Add support for MacBook7,1
Summary: [PATCH][asmc] Add support for MacBook7,1
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 12.1-RELEASE
Hardware: Any Any
: --- Affects Only Me
Assignee: Mark Johnston
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-16 17:34 UTC by gcx61
Modified: 2020-08-24 13:52 UTC (History)
1 user (show)

See Also:


Attachments
Add support for MacBook7,1 (1.56 KB, patch)
2020-08-16 17:34 UTC, gcx61
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description gcx61 2020-08-16 17:34:28 UTC
Created attachment 217264 [details]
Add support for MacBook7,1

Support for MacBook Mid-2010 is missing in asmc kernel module. I was able to implement such support with forum help. After applying attached patch, compiling and loading asmc module I'm able to check temperatures, set fan speed or see warnings from SMS (sudden motion sensors) on my machine. Looks like it's working without any errors. Some keys are missing description because I wasn't able to find any source which would provide such information but most keys are described.

Attachment provides patch for FreeBSD 12.1-RELEASE.
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-08-17 12:48:01 UTC
A commit references this bug:

Author: markj
Date: Mon Aug 17 12:47:08 UTC 2020
New revision: 364300
URL: https://svnweb.freebsd.org/changeset/base/364300

Log:
  asmc(4): Add support for MacBook7,1.

  PR:		248693
  Submitted by:	gcx61@interia.pl
  MFC after:	1 week

Changes:
  head/sys/dev/asmc/asmc.c
  head/sys/dev/asmc/asmcvar.h
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-08-24 13:51:49 UTC
A commit references this bug:

Author: markj
Date: Mon Aug 24 13:50:56 UTC 2020
New revision: 364676
URL: https://svnweb.freebsd.org/changeset/base/364676

Log:
  MFC r364300:
  asmc(4): Add support for MacBook7,1.

  PR:	248693

Changes:
_U  stable/12/
  stable/12/sys/dev/asmc/asmc.c
  stable/12/sys/dev/asmc/asmcvar.h
Comment 3 Mark Johnston freebsd_committer freebsd_triage 2020-08-24 13:52:35 UTC
Thanks for the patch.