Bug 248741 - net/mpd5: Fix build with -fno-common (clang 11 and gcc 10)
Summary: net/mpd5: Fix build with -fno-common (clang 11 and gcc 10)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Eugene Grosbein
Depends on:
Blocks: 248756
  Show dependency treegraph
Reported: 2020-08-18 21:11 UTC by Dimitry Andric
Modified: 2020-08-20 08:15 UTC (History)
0 users

See Also:
eugen: maintainer-feedback+

Fix build with -fno-common (clang 11 and gcc 10) (1.77 KB, patch)
2020-08-18 21:11 UTC, Dimitry Andric
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer 2020-08-18 21:11:59 UTC
Created attachment 217326 [details]
Fix build with -fno-common (clang 11 and gcc 10)

In base r364284, I imported clang 11 into head. Like gcc 10, it now defaults to -fno-common, meaning that duplicated global symbols will most likely lead to link errors. Here is a patch to fix this port's duplicated global symbols.
Comment 1 commit-hook freebsd_committer 2020-08-20 08:13:45 UTC
A commit references this bug:

Author: eugen
Date: Thu Aug 20 08:13:08 UTC 2020
New revision: 545507
URL: https://svnweb.freebsd.org/changeset/ports/545507

  net/mpd5: import r2272 from upstream

  This fixes build with -fno-common (clang 11 and gcc 10).
  PORTREVISION not bumped as it fixes build for FreeBSD 13.

  PR:		248741
  Reported by:	dim

Comment 2 Eugene Grosbein freebsd_committer 2020-08-20 08:15:18 UTC
Fixed with simplier patch. Thank you for the report!