Bug 248788 - emulators/simh: fix build problem on LLVM 11
Summary: emulators/simh: fix build problem on LLVM 11
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Stefan Eßer
URL:
Keywords:
Depends on:
Blocks: 248756
  Show dependency tree / graph
 
Reported: 2020-08-20 19:41 UTC by Bob Eager
Modified: 2021-01-04 13:00 UTC (History)
1 user (show)

See Also:

Attachments
Patch for Makefile (735 bytes, patch)
2020-08-20 19:41 UTC, Bob Eager 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bob Eager 2020-08-20 19:41:38 UTC 
Created attachment 217397 [details]
Patch for Makefile

simh does not build on LLVM 11. This is due to the default setting of -fno-common (previously -fcommon).

The upstream code depends on weak globals, so the fix is simply to provide -fcommon as part of CFLAGS.

Tested on 13-CURRENT and latest ports tree, using LLVM11 from ports.

This is a backward compatible fix.

Patch attached.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2020-08-21 06:11:04 UTC 
^Triage: [tags] in issue Titles are deprecated.
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.
--
Attachment -> Details -> maintainer-approval [+]
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2021-01-04 13:00:40 UTC 
This was fixed in ports r547263.

^Triage: Assign to committer resolving