Bug 248790 - Mk/Uses/cabal.mk: Add dependencies for make-use-cabal
Summary: Mk/Uses/cabal.mk: Add dependencies for make-use-cabal
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-haskell (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-20 20:50 UTC by Yuri Victorovich
Modified: 2020-09-06 14:32 UTC (History)
2 users (show)

See Also:

Attachments
patch (620 bytes, patch)
2020-08-20 20:50 UTC, Yuri Victorovich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2020-08-20 20:50:35 UTC 
Created attachment 217400 [details]
patch

make-use-cabal can only be used after cabal-extract and cabal-extract-deps, so it would be logical to add them as dependencies to minimize user confusion.
Comment 1 Gleb Popov freebsd_committer freebsd_triage 2020-09-06 14:32:46 UTC 
It is not that simple. The "cabal-extract" target can be substituted with "extract" in case of MASTER_SITES != Hackage. Moreover, Makefile dependencies are resolved by some output file, so for example "make-use-cabal" should check for some file created by "cabal-extract-deps".

I'm hesistant to commit this patch as is, so I'll close this for now. But if you come up with another one, please reopen this.