Bug 248845 - audio/squash: breaks under new -fno-common defaults (LLVM 11)
Summary: audio/squash: breaks under new -fno-common defaults (LLVM 11)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Matthias Andree
URL:
Keywords:
Depends on:
Blocks: 248756
  Show dependency tree / graph
 
Reported: 2020-08-23 09:07 UTC by Matthias Andree
Modified: 2020-08-23 09:08 UTC (History)
0 users

See Also:
mandree: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Andree freebsd_committer freebsd_triage 2020-08-23 09:07:44 UTC 
pkg-fallout reported duplicate symbols in the link stage for audio/squash, such as (a truckload full of these, to the point of the toolchain refusing to report more such issues):

ld: error: duplicate symbol: status_info
>>> defined at player.c
>>>            obj/player.o:(status_info)
>>> defined at playlist_manager.c
>>>            obj/playlist_manager.o:(.bss+0x248)
Comment 1 Matthias Andree freebsd_committer freebsd_triage 2020-08-23 09:08:18 UTC 
fixed in r545810
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-08-23 09:08:28 UTC 
A commit references this bug:

Author: mandree
Date: Sun Aug 23 09:08:09 UTC 2020
New revision: 545810
URL: https://svnweb.freebsd.org/changeset/ports/545810

Log:
  audio/squash: add -fcommon and LICENSE

  audio/squash is old code from 2004, add -fcommon to the compiler flags
  because that was the default when the code was developed. FreeBSD 13
  is apparently going to flip the switch to -fno-common, which causes
  linker failure.

  While here, add LICENSE and bump PORTREVISION.

  PR:		248845

Changes:
  head/audio/squash/Makefile