Bug 248872 - emulators/simh-hp3000: fix pkg fallout (build problem)
Summary: emulators/simh-hp3000: fix pkg fallout (build problem)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Kyle Evans
URL:
Keywords:
Depends on:
Blocks: 248756
  Show dependency treegraph
 
Reported: 2020-08-24 09:00 UTC by bob
Modified: 2020-08-29 02:27 UTC (History)
2 users (show)

See Also:
kevans: merge-quarterly+


Attachments
Proposed patch to be added to files/ (as a patch) (1.40 KB, patch)
2020-08-24 09:00 UTC, bob
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description bob 2020-08-24 09:00:08 UTC
Created attachment 217482 [details]
Proposed patch to be added to files/ (as a patch)

This patch fixes the the current build failure caused by the default setting of -f-no-common in LLVM 11.

No deleted files; one new file (patch in files/).

Additionally, removal of USES=compiler from Makefile, as the default compiler is used and expected; presence of this just causes confusion and makes testing more difficult.

Tested on LLVM 8 (12.1-RELEASE), LLVM 10 (13-CURRENT), and LLVM 11 (13-CURRENT, from ports) - all amd64.
Comment 1 bob 2020-08-24 09:00:43 UTC
PORTREVISION not bumped, as this is purely a build problem.
Comment 2 commit-hook freebsd_committer 2020-08-29 02:24:20 UTC
A commit references this bug:

Author: kevans
Date: Sat Aug 29 02:23:59 UTC 2020
New revision: 546866
URL: https://svnweb.freebsd.org/changeset/ports/546866

Log:
  emulators/simh-hp3000: fix the build with LLVM 11.

  Similar to the patch for emulators/simh-hp2100, drop an -fcommon in to fix
  the build in the face of GCC 10 / LLVM 11 switching the default to
  -fno-common.

  Minor cleanup while we're here, remove USES= compiler and just use ${CC} for
  the compiler.

  PR:		248872
  MFH:		2020Q3 (-fno-common build fix)

Changes:
  head/emulators/simh-hp3000/Makefile
  head/emulators/simh-hp3000/files/patch-SCP_makefile
Comment 3 Kyle Evans freebsd_committer 2020-08-29 02:27:15 UTC
Committed, thanks!
Comment 4 commit-hook freebsd_committer 2020-08-29 02:27:23 UTC
A commit references this bug:

Author: kevans
Date: Sat Aug 29 02:26:56 UTC 2020
New revision: 546868
URL: https://svnweb.freebsd.org/changeset/ports/546868

Log:
  MFH: r546866

  emulators/simh-hp3000: fix the build with LLVM 11.

  Similar to the patch for emulators/simh-hp2100, drop an -fcommon in to fix
  the build in the face of GCC 10 / LLVM 11 switching the default to
  -fno-common.

  Minor cleanup while we're here, remove USES= compiler and just use ${CC} for
  the compiler.

  PR:		248872

  Approved by:	ports-secteam (implicit, -fno-common build fix)

Changes:
_U  branches/2020Q3/
  branches/2020Q3/emulators/simh-hp3000/Makefile
  branches/2020Q3/emulators/simh-hp3000/files/patch-SCP_makefile