Bug 248976 - x11-wm/tvtwm: Fix link error: "ld: error: duplicate symbol: yylineno"
Summary: x11-wm/tvtwm: Fix link error: "ld: error: duplicate symbol: yylineno"
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Kyle Evans
URL:
Keywords:
Depends on:
Blocks: 248756
  Show dependency treegraph
 
Reported: 2020-08-28 17:54 UTC by david
Modified: 2020-08-28 18:13 UTC (History)
2 users (show)

See Also:
kevans: merge-quarterly+


Attachments
Patch to fix the "duplicate_symbol" whine (930 bytes, patch)
2020-08-28 17:54 UTC, david
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description david 2020-08-28 17:54:17 UTC
Created attachment 217598 [details]
Patch to fix the "duplicate_symbol" whine

I note that x11-wm/tvwm shows up on the list that Mark Linimon provided of "broken ports":

tvtwm-pl11_1.log: duplicate_symbol


As noted in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=248859, I am nearly certain that the fix for that port (x11-wm/piewm) also applies to tvtwm (as tvtwm is a direct ancestor of piewm).

I will provide a patch, but I am not the maintainer for this port (x11-wm/tvtwm), nor am I a committer.  I will try testing it tomorrow (when I can afford the time to boot my laptop to head).
Comment 1 Kyle Evans freebsd_committer 2020-08-28 18:04:50 UTC
(In reply to david from comment #0)

Patch looks good and builds fine; committing...
Comment 2 commit-hook freebsd_committer 2020-08-28 18:11:57 UTC
A commit references this bug:

Author: kevans
Date: Fri Aug 28 18:11:24 UTC 2020
New revision: 546780
URL: https://svnweb.freebsd.org/changeset/ports/546780

Log:
  x11-wm/tvtwm: Fix build with LLVM 11

  The fix for this is identical to that of x11-wm/piewm; remove the patch that
  explicitly de-externs yylineno when it's explicitly defined in another
  compilation unit (by flex).

  PR:		248976
  MFH:		2020Q3 (-fno-common build fix)

Changes:
  head/x11-wm/tvtwm/files/patch-gram.y
Comment 3 commit-hook freebsd_committer 2020-08-28 18:12:58 UTC
A commit references this bug:

Author: kevans
Date: Fri Aug 28 18:12:06 UTC 2020
New revision: 546781
URL: https://svnweb.freebsd.org/changeset/ports/546781

Log:
  MFH: r546780

  x11-wm/tvtwm: Fix build with LLVM 11

  The fix for this is identical to that of x11-wm/piewm; remove the patch that
  explicitly de-externs yylineno when it's explicitly defined in another
  compilation unit (by flex).

  PR:		248976

  Approved by:	ports-secteam (implicit, -fno-common build fix)

Changes:
_U  branches/2020Q3/
  branches/2020Q3/x11-wm/tvtwm/files/patch-gram.y