Created attachment 217639 [details] Patch to update science/libctl from 3.2.2 to 4.5.0 This patch updates science/libctl from 3.2.2 to 4.5.0. Over several minor and a major version release there have been important bugfixes and enhancements [1]. [1] https://github.com/NanoComp/libctl/blob/master/NEWS.md What this patch should do: - Update from 3.2.2 to 4.5.0 - Change from MASTER_SITES to USE_GITHUB - Add LIB_DEPENDS=devel/boehm-gc-threaded - Add USES=autoreconf - 'Bump' library version - Reorder some Makefile entries - Update pkg-plist The patch is tested on Poudriere (11.4i/a, 12.1i/a, and HEADi/a), 'portlint -AC' seems happy.
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/183535408
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field. Thanks!
(In reply to Fernando Apesteguía from comment #2) Hmm, I thought that link [1] from my initial description is the file, which contains the release informations. Please tell me, if that is not sufficient. [1] https://github.com/NanoComp/libctl/blob/master/NEWS.md
(In reply to Rainer Hurling from comment #3) Hi Rainer, Yes, that was great. It is better if it is in the URL field. It is easier to spot (and probably use from scripts). Thanks!
(In reply to Fernando Apesteguía from comment #4) Ah, ok. Thanks for the explanation. Next time I will use the URL field for this.
Hi there, The update of libctl to 4.5.0 breaks science/mpb: normal_vectors.c:128:6: error: use of undeclared identifier 'material_type' material_type m = { 0 }; ^ normal_vectors.c:133:24: error: use of undeclared identifier 'm' o = make_sphere(m, c, myurand(0.5,1.5)); ^ normal_vectors.c:136:26: error: use of undeclared identifier 'm' o = make_cylinder(m, c, myurand(0.5,1.5), myurand(0.5,1.5), ^ normal_vectors.c:140:22: error: use of undeclared identifier 'm' o = make_cone(m, c, myurand(0.5,1.5), myurand(0.5,1.5), ^ normal_vectors.c:144:23: error: use of undeclared identifier 'm' o = make_block(m, c, ^ normal_vectors.c:153:27: error: use of undeclared identifier 'm' o = make_ellipsoid(m, c, ^ 6 errors generated. *** Error code 1 Stop. make[3]: stopped in /wrkdirs/usr/ports/science/mpb/work/mpb-1.5/tests *** Error code 1 Stop. make[2]: stopped in /wrkdirs/usr/ports/science/mpb/work/mpb-1.5 *** Error code 1 Stop. make[1]: stopped in /wrkdirs/usr/ports/science/mpb/work/mpb-1.5 *** Error code 1 Stop. make: stopped in /usr/ports/science/mpb build of science/mpb | mpb-1.5_15 ended at Thu Sep 10 14:51:50 CEST 2020 build time: 00:00:53 !!! build failure encountered !!! Can you have a look at it?
(In reply to Fernando Apesteguía from comment #6) Hi Fernando, Thanks for the report and sorry for the breakage. If forgot to test science/mpb as a dependency. In fact, the update of science/libctl is planned as a prerequisite for the update of science/mpb (version 1.10.0). ATM, I do not understand the underlying problem. There are some changes in science/libctl and it seems, that 'material_type m = { 0 };' does not fit the needs any more. Do you have an idea how to solve the "use of undeclared identifier 'm'" error?
(In reply to Rainer Hurling from comment #7) Hi Rainer, No worries, nothing is broken yet :-) Unfortunately I didn't have time to have a look at the problem. I'm going to be AFK for a week and a half. I'll be glad to help you out when I come back if it is not solved by then. Any other committers are welcome to take this PR over, too! :-)
(In reply to Fernando Apesteguía from comment #8) > No worries, nothing is broken yet :-) Thanks :) > Unfortunately I didn't have time to have a look at the problem. I'm going > to be AFK for a week and a half. I'll be glad to help you out when I come > back if it is not solved by then. No hurry. science/mpb is 'my' port, so the update can wait some more time. The existing version is usable. I will be glad to get some help with the new version of mpb, because I do not understand what is going wrong there in the build process. I also, will be AFK from next Monday to Saturday.
Reassigning to reporter who is now a committer.
Created attachment 219150 [details] Update to 4.5.0; - Change back to MASTER_SITES, now that Github archives are usable - Update URL in pkg-descr Waiting for maintainer feedback now :)
Maintainer Timeout :(
Let's commit it.
Thanks for your reply. The update is in the review process on Phabricator :)
A commit references this bug: Author: rhurlin Date: Sat Oct 31 15:59:09 UTC 2020 New revision: 553774 URL: https://svnweb.freebsd.org/changeset/ports/553774 Log: science/libctl: Update to 4.5.0 Update science/libctl from 3.2.2 to 4.5.0. Over several minor and a major version release there have been important bugfixes and enhancements [1]. [1] https://github.com/NanoComp/libctl/blob/master/NEWS.md What this patch should do: - Update from 3.2.2 to 4.5.0 - Change MASTER_SITES to the Github releases URL - Add LIB_DEPENDS=devel/boehm-gc-threaded and libguile-2.2.so:lang/guile2 - 'Bump' library version - Set option NLOPT default (needed by science/mpb) - Reorder some Makefile entries - Update URL in pkg-descr - Update pkg-plist PR: 249007 Submitted by: (maintainer timeout) Approved by: arrowd (mentor) Differential Revision: https://reviews.freebsd.org/D26992 Changes: head/science/libctl/Makefile head/science/libctl/distinfo head/science/libctl/pkg-descr head/science/libctl/pkg-plist
Committed, thanks :)