Bug 249007 - science/libctl: Update to 4.5.0
Summary: science/libctl: Update to 4.5.0
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rainer Hurling
URL: https://github.com/NanoComp/libctl/bl...
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2020-08-30 06:43 UTC by Rainer Hurling
Modified: 2020-10-29 05:33 UTC (History)
3 users (show)

See Also:
rhurlin: maintainer-feedback+


Attachments
Patch to update science/libctl from 3.2.2 to 4.5.0 (3.63 KB, patch)
2020-08-30 06:43 UTC, Rainer Hurling
no flags Details | Diff
Update to 4.5.0; (4.09 KB, patch)
2020-10-27 20:01 UTC, Rainer Hurling
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rainer Hurling freebsd_committer 2020-08-30 06:43:41 UTC
Created attachment 217639 [details]
Patch to update science/libctl from 3.2.2 to 4.5.0

This patch updates science/libctl from 3.2.2 to 4.5.0. Over several minor and a major version release there have been important bugfixes and enhancements [1].

[1] https://github.com/NanoComp/libctl/blob/master/NEWS.md


What this patch should do:

- Update from 3.2.2 to 4.5.0
- Change from MASTER_SITES to USE_GITHUB
- Add LIB_DEPENDS=devel/boehm-gc-threaded
- Add USES=autoreconf
- 'Bump' library version
- Reorder some Makefile entries
- Update pkg-plist


The patch is tested on Poudriere (11.4i/a, 12.1i/a, and HEADi/a),
'portlint -AC' seems happy.
Comment 1 Automation User 2020-08-30 13:28:24 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/183535408
Comment 2 Fernando Apesteguía freebsd_committer 2020-09-01 16:31:55 UTC
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

Thanks!
Comment 3 Rainer Hurling freebsd_committer 2020-09-01 16:38:36 UTC
(In reply to Fernando Apesteguía from comment #2)

Hmm, I thought that link [1] from my initial description is the file, which contains the release informations.
Please tell me, if that is not sufficient.


[1] https://github.com/NanoComp/libctl/blob/master/NEWS.md
Comment 4 Fernando Apesteguía freebsd_committer 2020-09-01 16:43:37 UTC
(In reply to Rainer Hurling from comment #3)

Hi Rainer,

Yes, that was great. It is better if it is in the URL field. It is easier to spot (and probably use from scripts).

Thanks!
Comment 5 Rainer Hurling freebsd_committer 2020-09-01 16:47:15 UTC
(In reply to Fernando Apesteguía from comment #4)

Ah, ok. Thanks for the explanation. Next time I will use the URL field for this.
Comment 6 Fernando Apesteguía freebsd_committer 2020-09-10 11:54:29 UTC
Hi there,

The update of libctl to 4.5.0 breaks science/mpb:

normal_vectors.c:128:6: error: use of undeclared identifier 'material_type'
     material_type m = { 0 };
     ^
normal_vectors.c:133:24: error: use of undeclared identifier 'm'
              o = make_sphere(m, c, myurand(0.5,1.5));
                              ^
normal_vectors.c:136:26: error: use of undeclared identifier 'm'
              o = make_cylinder(m, c, myurand(0.5,1.5), myurand(0.5,1.5),
                                ^
normal_vectors.c:140:22: error: use of undeclared identifier 'm'
              o = make_cone(m, c, myurand(0.5,1.5), myurand(0.5,1.5),
                            ^
normal_vectors.c:144:23: error: use of undeclared identifier 'm'
              o = make_block(m, c,
                             ^
normal_vectors.c:153:27: error: use of undeclared identifier 'm'
              o = make_ellipsoid(m, c,
                                 ^
6 errors generated.
*** Error code 1

Stop.
make[3]: stopped in /wrkdirs/usr/ports/science/mpb/work/mpb-1.5/tests
*** Error code 1

Stop.
make[2]: stopped in /wrkdirs/usr/ports/science/mpb/work/mpb-1.5
*** Error code 1

Stop.
make[1]: stopped in /wrkdirs/usr/ports/science/mpb/work/mpb-1.5
*** Error code 1

Stop.
make: stopped in /usr/ports/science/mpb
build of science/mpb | mpb-1.5_15 ended at Thu Sep 10 14:51:50 CEST 2020
build time: 00:00:53
!!! build failure encountered !!!

Can you have a look at it?
Comment 7 Rainer Hurling freebsd_committer 2020-09-10 20:28:30 UTC
(In reply to Fernando Apesteguía from comment #6)

Hi Fernando,

Thanks for the report and sorry for the breakage. If forgot to test science/mpb as a dependency. 

In fact, the update of science/libctl is planned as a prerequisite for the update of science/mpb (version 1.10.0).


ATM, I do not understand the underlying problem. There are some changes in science/libctl and it seems, that 'material_type m = { 0 };' does not fit the needs any more. Do you have an idea how to solve the "use of undeclared identifier 'm'" error?
Comment 8 Fernando Apesteguía freebsd_committer 2020-09-11 10:04:29 UTC
(In reply to Rainer Hurling from comment #7)

Hi Rainer,

No worries, nothing is broken yet :-)

Unfortunately I didn't have time to have a look at the problem. I'm going to be AFK for a week and a half. I'll be glad to help you out when I come back if it is not solved by then.

Any other committers are welcome to take this PR over, too! :-)
Comment 9 Rainer Hurling freebsd_committer 2020-09-11 11:24:30 UTC
(In reply to Fernando Apesteguía from comment #8)

> No worries, nothing is broken yet :-)

Thanks :)

> Unfortunately I didn't have time to have a look at the problem. I'm going 
> to be AFK for a week and a half. I'll be glad to help you out when I come
> back if it is not solved by then.

No hurry. science/mpb is 'my' port, so the update can wait some more time. The existing version is usable. I will be glad to get some help with the new version of mpb, because I do not understand what is going wrong there in the build process.

I also, will be AFK from next Monday to Saturday.
Comment 10 Fernando Apesteguía freebsd_committer 2020-10-02 07:19:33 UTC
Reassigning to reporter who is now a committer.
Comment 11 Rainer Hurling freebsd_committer 2020-10-27 20:01:29 UTC
Created attachment 219150 [details]
Update to 4.5.0;

- Change back to MASTER_SITES, now that Github archives are usable
- Update URL in pkg-descr


Waiting for maintainer feedback now :)
Comment 12 Rainer Hurling freebsd_committer 2020-10-28 20:31:45 UTC
Maintainer Timeout :(
Comment 13 devel 2020-10-29 04:37:25 UTC
Let's commit it.
Comment 14 Rainer Hurling freebsd_committer 2020-10-29 05:33:49 UTC
Thanks for your reply. The update is in the review process on Phabricator :)