Bug 249013 - japanese/mh: Fix build failure on -current (with -fno-common)
Summary: japanese/mh: Fix build failure on -current (with -fno-common)
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: buildisok
Depends on:
Blocks: 248756
  Show dependency treegraph
 
Reported: 2020-08-30 12:44 UTC by WATANABE Kazuhiro
Modified: 2020-08-31 02:18 UTC (History)
0 users

See Also:
koobs: merge-quarterly?


Attachments
A patch for japanese/mh. (2.11 KB, patch)
2020-08-30 12:44 UTC, WATANABE Kazuhiro
CQG00620: maintainer-approval+
Details | Diff
poudriere testport log on 13.0-CURRENT without the patch (671.81 KB, text/plain)
2020-08-30 12:48 UTC, WATANABE Kazuhiro
no flags Details
poudriere testport log on 13.0-CURRENT with the patch (705.29 KB, text/plain)
2020-08-30 12:49 UTC, WATANABE Kazuhiro
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description WATANABE Kazuhiro 2020-08-30 12:44:51 UTC
Created attachment 217648 [details]
A patch for japanese/mh.

Current japanese/mh fails to build on 13.0-CURRENT due to the new default -fno-common compiler flag:

| ld: error: duplicate symbol: wantcomp
| >>> defined at fmtcompile.c
| >>>            fmtcompile.o:(wantcomp)
| >>> defined at formatsbr.c
| >>>            formatsbr.o:(.bss+0x60)
| cc: error: linker command failed with exit code 1 (use -v to see invocation)

This patch fixes the problem.
Comment 1 WATANABE Kazuhiro 2020-08-30 12:48:34 UTC
Created attachment 217649 [details]
poudriere testport log on 13.0-CURRENT without the patch
Comment 2 WATANABE Kazuhiro 2020-08-30 12:49:15 UTC
Created attachment 217650 [details]
poudriere testport log on 13.0-CURRENT with the patch
Comment 3 Automation User 2020-08-30 13:38:23 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/183578169