Bug 249235 - security/py-bcrypt: Fix runtime dependencies
Summary: security/py-bcrypt: Fix runtime dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Danilo G. Baio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-10 13:36 UTC by Andrew Fyfe
Modified: 2020-09-12 02:00 UTC (History)
1 user (show)

See Also:
dbaio: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fyfe 2020-09-10 13:36:10 UTC
devel/py-cffi and devel/py-six are listed as build dependencies, they are also required at runtime for this python module to function as seen in the example below.

user@cal ~ # pkg install python3 py37-bcrypt
user@cal ~ # python3 -c 'import bcrypt'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/local/lib/python3.8/site-packages/bcrypt/__init__.py", line 25, in <module>
    from . import _bcrypt
ModuleNotFoundError: No module named '_cffi_backend'


These missing dependencies are causing issues for other packages that require security/py-bcrypt ie bug #245906, comment #13
Comment 1 Andrew Fyfe 2020-09-10 13:40:46 UTC
(In reply to Andrew Fyfe from comment #0)

There was a copy paste error in the above example, I've tested this with both Python 3.7 and 3.8:

user@cal ~ # pkg install python3 py37-bcrypt
user@cal ~ # python3 -c 'import bcrypt'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/local/lib/python3.7/site-packages/bcrypt/__init__.py", line 25, in <module>
    from . import _bcrypt
ModuleNotFoundError: No module named '_cffi_backend'
Comment 2 Danilo G. Baio freebsd_committer 2020-09-12 01:50:46 UTC
Confirmed, thanks for reporting it.
Comment 3 commit-hook freebsd_committer 2020-09-12 01:56:26 UTC
A commit references this bug:

Author: dbaio
Date: Sat Sep 12 01:56:08 UTC 2020
New revision: 548276
URL: https://svnweb.freebsd.org/changeset/ports/548276

Log:
  security/py-bcrypt: Fix runtime dependencies

  PR:		249235
  Reported by:	Andrew Fyfe <andrew@neptune-one.net>
  MFH:		2020Q3 (blanket: runtime fix)

Changes:
  head/security/py-bcrypt/Makefile
Comment 4 commit-hook freebsd_committer 2020-09-12 01:59:28 UTC
A commit references this bug:

Author: dbaio
Date: Sat Sep 12 01:59:18 UTC 2020
New revision: 548277
URL: https://svnweb.freebsd.org/changeset/ports/548277

Log:
  MFH: r548276

  security/py-bcrypt: Fix runtime dependencies

  PR:		249235
  Reported by:	Andrew Fyfe <andrew@neptune-one.net>

  Approved by:	ports-secteam (blanket: runtime fix)

Changes:
_U  branches/2020Q3/
  branches/2020Q3/security/py-bcrypt/Makefile
Comment 5 Danilo G. Baio freebsd_committer 2020-09-12 02:00:25 UTC
Committed, thank you!