Bug 249450 - devel/gvfs: Update to 1.46.0
Summary: devel/gvfs: Update to 1.46.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Baptiste Daroussin
Depends on: 247278
  Show dependency treegraph
Reported: 2020-09-19 12:41 UTC by Olivier Duchateau
Modified: 2020-10-12 10:15 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)

Patch to update devel/gvfs (23.00 KB, patch)
2020-09-19 12:41 UTC, Olivier Duchateau
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Duchateau 2020-09-19 12:41:04 UTC
Created attachment 218076 [details]
Patch to update devel/gvfs

- Update to 1.46.0
- Adjust dependencies
- Switch to the Meson build system
- Create slave ports (instead of options) for Avahi, Google/GNOME Online Accounts, Samba and NFS

CC'ed the desktop team, and Xfce (GVfs is also used by Thunar for trash and network protocols).
Comment 1 Olivier Duchateau 2020-09-19 12:41:54 UTC
It requires an update of GLib, bug #247278
Comment 2 Baptiste Daroussin freebsd_committer 2020-09-30 13:39:19 UTC
I do find the split rather complicated, I think it would be better served by subpackages when they will be finalize, in the meantime I would prefer to merge them back into a single port with maybe options.

gudev is something we have I don't see why not having it on here.
Why do you also disable udisk2 while it working properly with the bsddisk backend ?
Comment 3 Olivier Duchateau 2020-09-30 18:41:33 UTC
(In reply to Baptiste Daroussin from comment #2)

udisks2 does not work with all file managers
Comment 4 Charlie Li 2020-09-30 20:03:12 UTC
(In reply to Olivier Duchateau from comment #3)
> udisks2 does not work with all file managers
Then that is a bug with those file managers at the very least, unless those upstreams specifically did not design or intend for udisks2. udisks2 isn't exactly optional for gvfs.

Also remember that our libudisks2 is only the library part; sysutils/bsdisks is the implementation, as bapt@ pointed out. Both need to be dependencies.

Here's what I have running, even though it's 1.44, not 1.46 https://github.com/freebsd/freebsd-ports-gnome/blob/0066b3f1b979b1546aaac1493330312b8fcdc6b1/devel/gvfs/Makefile
Comment 5 commit-hook freebsd_committer 2020-10-12 10:14:56 UTC
A commit references this bug:

Author: bapt
Date: Mon Oct 12 10:14:46 UTC 2020
New revision: 552113
URL: https://svnweb.freebsd.org/changeset/ports/552113

  Update gvfs to 1.46.1

  This version if a mix of the version proposed in PR by Olivier Duchateau and
  the version sent in the gnome repo by Charlie Li <git@vishwin.info>

  Olivier proposed a split of the port, which hasn't been taken in because it makes
  things more complicated to maintained and will be better served by subpackages when
  they will hit the tree.

  PR:	 249450
  Github:	https://github.com/freebsd/freebsd-ports-gnome/commit/0066b3f1b979b1546aaac1493330312b8fcdc6b1