Bug 249591 - comms/uhd: depends on python 2.x
Summary: comms/uhd: depends on python 2.x
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Michael Reifenberger
URL: https://github.com/EttusResearch/uhd/...
Keywords:
Depends on:
Blocks: 249337
  Show dependency treegraph
 
Reported: 2020-09-24 16:20 UTC by Steve Wills
Modified: 2020-10-19 18:42 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (mr)


Attachments
Unready patch to comms/uhd 4.0.0.0 (4.79 KB, patch)
2020-10-04 13:13 UTC, Rainer Hurling
no flags Details | Diff
Draft patch for comms/uhd 4.0.0.0, now buildable and installable (229.78 KB, patch)
2020-10-16 10:56 UTC, Rainer Hurling
no flags Details | Diff
Patch for comms/uhd 4.0.0.0, buildable and installable (230.29 KB, patch)
2020-10-16 17:46 UTC, Rainer Hurling
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Wills freebsd_committer 2020-09-24 16:20:08 UTC
This port will be removed on 2020-12-31 if not fixed
Comment 1 Rainer Hurling freebsd_committer 2020-10-04 13:13:16 UTC
Created attachment 218513 [details]
Unready patch to comms/uhd 4.0.0.0

Hi Michael,

Don't know, if you are already in preparation for a patch. 

I investaged a bit towards an update to version 4.0.0.0. The attached patch contains some changes about what 'portlint -AC' complains and a new dependency devel/py-ruamel.yaml. ATM, devel/py-cheetah hinders the build and test of the updated uhd port, because py-cheetah has no py37 flavor[1].

If you want, please feel free to use this diff as a starting point, for further changes.


[1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=249630
Comment 2 Rainer Hurling freebsd_committer 2020-10-16 10:56:12 UTC
Created attachment 218792 [details]
Draft patch for comms/uhd 4.0.0.0, now buildable and installable

Hi Michael,

After some searching I found out, that found out that there already exists a suitable port devel/py-cheetah3, so the configure now runs as expected, the port builds and installs. I prepared an updated patch, please feel free to use it if needed.


Most of UHD's binaries seem to run, but 'uhd_find_devices' core dumps (I had no device connected!). At this point there is obviously still some work to be done.

#uhd_config_info --print-all
UHD 4.0.0.0-0-unknown
Build date: Fri, 16 Oct 2020 09:54:54
C compiler: Clang 11.0.0
C++ compiler: Clang 11.0.0
C flags: -DBOOST_ERROR_CODE_HEADER_ONLY -DBOOST_ASIO_DISABLE_STD_STRING_VIEW -DBOOST_ASIO_DISABLE_STD_EXPERIMENTAL_STRING_VIEW -DHAVE_CONFIG_H -DUHD_LOG_MIN_LEVEL=1 -DUHD_LOG_CONSOLE_LEVEL=2 -DUHD_LOG_FILE_LEVEL=2 -DUHD_LOG_CONSOLE_COLOR-O2 -pipe  -fstack-protector-strong -fno-strict-aliasing
C++ flags: -DBOOST_ERROR_CODE_HEADER_ONLY -DBOOST_ASIO_DISABLE_STD_STRING_VIEW -DBOOST_ASIO_DISABLE_STD_EXPERIMENTAL_STRING_VIEW -DHAVE_CONFIG_H -DUHD_LOG_MIN_LEVEL=1 -DUHD_LOG_CONSOLE_LEVEL=2 -DUHD_LOG_FILE_LEVEL=2 -DUHD_LOG_CONSOLE_COLOR-stdlib=libc++ -O2 -pipe -fstack-protector-strong -fno-strict-aliasing  -msse2 -std=c++11 -fvisibility=hidden -fvisibility-inlines-hidden
Enabled components: LibUHD, LibUHD - C API, LibUHD - Python API, Examples, Utils, Tests, USB, B100, B200, USRP1, USRP2, X300, MPMD, N300, N320, E320, E300, OctoClock
Install prefix: /usr/local
Boost version: 1.72
Libusb version: 1.0.20
Library path: /usr/local/lib
Package path: /usr/local
Images directory: 
ABI version string: 4.0.0


#uhd_usrp_probe 
[INFO] [UHD] FreeBSD 13; Clang version 11.0.0 (git@github.com:llvm/llvm-project.git llvmorg-11.0.0-rc5-0-g60a25202a7d); Boost_107200; UHD_4.0.0.0-0-unknown
[ERROR] [UHD] Device discovery error: send_to: Can't assign requested address
Error: LookupError: KeyError: No devices found for ----->
Empty Device Address


#uhd_find_devices 
[INFO] [UHD] FreeBSD 13; Clang version 11.0.0 (git@github.com:llvm/llvm-project.git llvmorg-11.0.0-rc5-0-g60a25202a7d); Boost_107200; UHD_4.0.0.0-0-unknown
Speicherschutzverletzung(core dumped)


Another issue only occurs on Poudriere, not on a real life box:

using ${STRIP_CMD}
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: %%DATADIR%%/examples/python/benchmark_rate.py
Error: Missing: %%DATADIR%%/examples/python/curses_fft.py
Error: Missing: %%DATADIR%%/examples/python/rx_to_file.py
Error: Missing: %%DATADIR%%/examples/python/tx_waveforms.py
Error: Missing: %%DATADIR%%/examples/python/usrp_power_meter.py
Error: Missing: %%DATADIR%%/tests/pychdr_parse_test.py
Error: Missing: %%DATADIR%%/tests/pyranges_test.py
Error: Missing: %%DATADIR%%/tests/verify_fbs_test.py
===> Error: Plist issues found.
Comment 3 Rainer Hurling freebsd_committer 2020-10-16 17:46:58 UTC
Created attachment 218805 [details]
Patch for comms/uhd 4.0.0.0, buildable and installable

- New pkg-plist, which is ok for Poudriere.
- ${STRIP_CMD} for several files under ${DATADIR}/utils/.
- Order BROKEN_* before _DEPENDS

The core_dump, described in comment #2 for uhd_find_devices, still happens.
Comment 4 commit-hook freebsd_committer 2020-10-19 18:33:14 UTC
A commit references this bug:

Author: mr
Date: Mon Oct 19 18:33:05 UTC 2020
New revision: 552756
URL: https://svnweb.freebsd.org/changeset/ports/552756

Log:
  Update to release 4.0.0.0 and use python 3.6+

  PR:		249591
  Submitted by:	rhurlin@

Changes:
  head/comms/uhd/Makefile
  head/comms/uhd/distinfo
  head/comms/uhd/pkg-descr
  head/comms/uhd/pkg-plist
Comment 5 Michael Reifenberger freebsd_committer 2020-10-19 18:42:11 UTC
Hi,
thanks providing a patch.
So far I don't get dumps in the mentioned programs (#2)