Bug 249620 - devel/libclc: depends on python 2.x
Summary: devel/libclc: depends on python 2.x
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
Depends on:
Blocks: 249337
  Show dependency treegraph
Reported: 2020-09-24 16:22 UTC by Steve Wills
Modified: 2021-10-19 20:28 UTC (History)
5 users (show)

See Also:
bugzilla: maintainer-feedback? (x11)
jbeich: maintainer-feedback? (brooks)

libclc.patch (llvm 11.0.0) (19.25 KB, patch)
2020-10-16 17:15 UTC, Val Packett [:unrelentingtech]
val: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Wills freebsd_committer 2020-09-24 16:22:25 UTC
This port will be removed on 2020-12-31 if not fixed
Comment 1 Val Packett [:unrelentingtech] 2020-10-16 17:15:05 UTC
Created attachment 218803 [details]
libclc.patch (llvm 11.0.0)

libclc is part of the LLVM repo now, the separate mirror is no longer updated.
Versioning is quite confusing: pkg-config version is stuck at 0.2.0, the tag from the mirror was 0.4.0, but now it's in LLVM so it follows LLVM.

The python2 based build system is dropped: https://github.com/llvm/llvm-project/commit/d6e0e6d255a7d54a3873b7a5d048eee00ef6bb6d#diff-eadd7e7d6ad9e3f2b2ca4010924946948dac2350f8b901e9744c10a79ecdb92e

The attached patch builds libclc from llvm-project 11.0.0, using CMake.
(also resets BROKEN_powerpc64 because let's try again)

Clover must be rebuilt (PORTREVISION bumped) when switching to this version, since the directory for the bytecode files has moved from lib to share, and apparently clover gets this path compiled in via headers or something.
Comment 2 Niclas Zeising freebsd_committer 2020-10-26 15:05:48 UTC
How hard would it be to make libclc part of the normal llvm package, if it is now part of llvm properly?
Comment 3 Jan Beich freebsd_committer 2020-10-27 06:33:45 UTC
(In reply to Niclas Zeising from comment #2)
> How hard would it be to make libclc part of the normal llvm package,
> if it is now part of llvm properly?

Maybe devel/llvm* can answer.
Comment 4 Brooks Davis freebsd_committer 2020-10-27 16:24:31 UTC
I'll take a look at adding to llvm-devel to start out.

The libclc README seems to be woefully out of data so it's not completely clear how I build it all in one piece or exactly when it can/should be built (e.g. do I have to key off of particular backends being present).
Comment 5 Val Packett [:unrelentingtech] 2020-10-27 17:22:44 UTC
I'm not sure if "build everything in devel/llvm*" is a good idea right now (in the absence of multiple-packages-from-one-port support in the system) – someone installing llvm might not want all this extra stuff (and libclc is a big package, the build makes precompiled binaries for loads of GPUs).
Comment 6 Brooks Davis freebsd_committer 2020-10-27 18:06:39 UTC
FYI, I tried adding libclc to the projects list and it didn't fail, but AFACT didn't build anything either.  I think it's meant to be built separately (which the README somewhat implies).
Comment 7 Steve Wills freebsd_committer 2020-12-16 15:30:06 UTC
(In reply to Greg V from comment #1)
Can you please update this so that it doesn't set LLVM_DEFAULT? Thanks!
Comment 8 Ghost 2021-06-13 21:07:02 UTC
devel/libclc no longer depends on python 2.x as of:
Comment 9 Brooks Davis freebsd_committer 2021-10-19 20:28:44 UTC
This is reported fixed (and I see one a python38 dependency in my tree.