Created attachment 218276 [details] Patch to update x11-toolkits/pango - Update to 1.46.2 - Adjust dependencies - Remove X11 option - Remove patches
Moin moin Thank you for the patch. mfg Tobias
Moin moin What was the reasoning behind dropping the X11 option? mfg Tobias
Created attachment 218327 [details] v1 Moin moin Based on your patch here's an updated version which keeps the X11 option around. mfg Tobias
desktop@ would like to ask for an exp-run of this patch (v1), which can also be found here: https://people.freebsd.org/~tcberner/patches/pango-1.46.2.v1.diff mfg Tobias
(In reply to Tobias C. Berner from comment #2) Because when I submitted an update of Gtk3 bug #249288, comment #3 I remove support of X11. Wayland support for the Xfce desktop is not planned for the next stable major release.
I think it's not really a question of X11 vs Wayland, more of X11 vs NOX11 here.
Some new failures on 12.1 i386: http://pb2.nyi.freebsd.org/data/121i386-default-PR244494/2020-09-30_09h33m47s/logs/errors/codelite-12.0_4.log http://pb2.nyi.freebsd.org/data/121i386-default-PR244494/2020-09-30_09h33m47s/logs/errors/pcsxr-1.9.95.20180604_3.log http://pb2.nyi.freebsd.org/data/121i386-default-PR244494/2020-09-30_09h33m47s/logs/errors/eiskaltdcpp-gtk-2.2.10_20.log http://pb2.nyi.freebsd.org/data/121i386-default-PR244494/2020-09-30_09h33m47s/logs/errors/gtkhtml3-3.32.1_5.log http://pb2.nyi.freebsd.org/data/121i386-default-PR244494/2020-09-30_09h33m47s/logs/errors/pangox-compat-0.0.2_2.log http://pb2.nyi.freebsd.org/data/121i386-default-PR244494/2020-09-30_09h33m47s/logs/errors/py27-gtk2-2.24.0_5.log
Now 1.47.0 is out (and is required by gtk4 3.99.2)… not much change between these, just bump the version. > eiskaltdcpp-gtk-2.2.10_20.log > fatal error: 'hb.h' file not found hmmm it's getting cflags for pango transitively from something, and that something doesn't include -I/usr/local/include/harfbuzz > Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE) oh well it's even getting that something from CMake's magic finders, maybe USES+=pkgconfig is a good idea? > codelite-12.0_4.log > pcsxr-1.9.95.20180604_3.log same thing in these but pkgconf is used >_< Maybe just CFLAGS+=-I${LOCALBASE}/include/harfbuzz these as a hot fix.. > gtkhtml3-3.32.1_5.log > error: implicit declaration of function 'pango_find_base_dir' is invalid in C99 -DPANGO_DISABLE_DEPRECATED must be removed in this port. > pangox-compat-0.0.2_2.log > pangox.c:282:15: error: no member named 'find_shaper' in 'struct _PangoFontClass' Arch Linux simply commented out that line: https://aur.archlinux.org/cgit/aur.git/tree/0002-disable-shaper.patch?h=pangox-compat > py27-gtk2-2.24.0_5.log same here but the fix has been merged: https://gitlab.gnome.org/Archive/pygtk/-/merge_requests/1 so it should be updated to the latest git master https://gitlab.gnome.org/Archive/pygtk/-/commits/master/
(In reply to Greg V from comment #8) 1.47.0 is development version? GNOME project uses this versioning sheme: - odd number is devel release - even number is stable release
Oh actually— > py27-gtk2-2.24.0_5.log just got killed (yay!) https://svnweb.freebsd.org/ports?view=revision&revision=552492 (In reply to Olivier Duchateau from comment #9) I'm not sure if pango follows the same scheme, maybe.
Created attachment 219910 [details] Patch for pango - v1.48.0 Update to newest release, based on tcberner's patch.
* codelite --> Probably similar story as eiskaltdcpp (outdated and newer versions fixes issues) * eiskaltdcpp --> Bump to latest commit and hope for the best (?) https://github.com/eiskaltdcpp/eiskaltdcpp/releases/tag/v2.2.10 There are also build fixes for deps such as Pango https://github.com/eiskaltdcpp/eiskaltdcpp/commit/8b22479aef21fb2b764051f0499ae5fba397d31f * pcsxr --> Drop? The interesting parts are ported to libretro / retroarch https://github.com/iCatButler/pcsxr/pull/21 https://github.com/libretro/pcsx1-libretro * gtkhtml3 --> Deprecate? Dead upstream https://gitlab.gnome.org/Archive/gtkhtml * pangox-compat --> Deprecate? Dead upstream https://gitlab.gnome.org/Archive/pangox-compat Arch Linux seems to have a working version https://aur.archlinux.org/packages/pangox-compat/
(In reply to daniel.engberg.lists from comment #12) * pangox-compat is uised by a handfull of ports, is it really needed?
At least anydesk requires it, I guess we "need" to fix pangox-compat for now....
martymac@ Can you have a look at pcsxr? Perhaps worth considering removing it as upstream is dead and we have retroarch (libretro) in ports? https://www.freshports.org/games/libretro-beetle_psx/ https://www.freshports.org/games/libretro-pcsx_rearmed/ Best regards, Daniel
fjoe@ Can you have a look at eiskaltdcc? There's a new release available which I guess should fix (all?) the build issues https://github.com/eiskaltdcpp/eiskaltdcpp/releases/tag/v2.4.0 Best regards, Daniel
Created attachment 221639 [details] Patch for pango - v1.48.0 v2 Add help2man build dep
(In reply to daniel.engberg.lists from comment #15) Hello Daniel, Thanks for your work on this. Pcsxr is dead upstream, but I like this emulator as it is a standalone one. Feel free to mark it as BROKEN with the update ; I'll then see if it can be fixed by including harfbuzz include dirs (I'm busy with tbb upgrade right now). Best regards, Ganael.
Hi Ganael, Unless you have a strong attachment to pcsxr perhaps it would be worth deprecating it in favour of duckstation ( https://github.com/stenzek/duckstation ) which is actively maintained instead even if I personally would like to see most of our efforts being directed to retroarch especially since it carries all cores. Best regards, Daniel