Bug 249895 - devel/nlohmann-json: Request to install include/nlohmann/json_fwd.hpp
Summary: devel/nlohmann-json: Request to install include/nlohmann/json_fwd.hpp
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mateusz Piotrowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-25 20:51 UTC by Mateusz Piotrowski
Modified: 2020-09-25 22:06 UTC (History)
1 user (show)

See Also:
yuri: maintainer-feedback+

Attachments
Install all headers (3.22 KB, patch)
2020-09-25 21:39 UTC, Mateusz Piotrowski 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mateusz Piotrowski freebsd_committer freebsd_triage 2020-09-25 20:51:19 UTC 
The include/nlohmann/json_fwd.hpp file is going to be required by future versions of sysutils/nix. Would it be possible to include it in the default package?

Thanks!
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2020-09-25 21:04:20 UTC 
Yes,

Please go ahead and alter devel/nlohmann-json to add this file.

Thanks,
Yuri
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-09-25 21:18:33 UTC 
A commit references this bug:

Author: 0mp
Date: Fri Sep 25 21:18:30 UTC 2020
New revision: 550083
URL: https://svnweb.freebsd.org/changeset/ports/550083

Log:
  devel/nlohmann-json: Install include/nlohmann/json_fwd.hpp

  This header file is required by future versions of sysutils/nix.

  In order to get that header installed, the JSON_MultipleHeaders option had
  to be enable. This option results in the build system installing a lot of
  other header files as well. As there is no need to ship those other headers
  at the moment, let's delete them in post-install.

  PR:		249895
  Approved by:	yuri@ (maintainer)

Changes:
  head/devel/nlohmann-json/Makefile
Comment 3 Mateusz Piotrowski freebsd_committer freebsd_triage 2020-09-25 21:20:18 UTC 
Done! Thanks!
Comment 4 Mateusz Piotrowski freebsd_committer freebsd_triage 2020-09-25 21:26:15 UTC 
Wait, it turns out that that's not all.

It looks like I need some other headers as well, which are currently deleted in post-install. I wonder if we should just install all the headers at this point.

What do you think?
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2020-09-25 21:34:17 UTC 
(In reply to Mateusz Piotrowski from comment #4)

What are these headers?
Comment 6 Mateusz Piotrowski freebsd_committer freebsd_triage 2020-09-25 21:39:27 UTC 
Created attachment 218298 [details]
Install all headers

(In reply to Yuri Victorovich from comment #5)

Hmm, it looks like if you specify JSON_MultipleHeaders then you just need all the headers anyway, because json.hpp one is now depending on them.

As a result, I think that the last commit broke the port.

Here's the patch which installs all the headers.
Comment 7 Yuri Victorovich freebsd_committer freebsd_triage 2020-09-25 21:40:54 UTC 
(In reply to Mateusz Piotrowski from comment #6)

Ah, yes, please add them too.

Yuri
Comment 8 commit-hook freebsd_committer freebsd_triage 2020-09-25 21:45:40 UTC 
A commit references this bug:

Author: 0mp
Date: Fri Sep 25 21:44:47 UTC 2020
New revision: 550086
URL: https://svnweb.freebsd.org/changeset/ports/550086

Log:
  devel/nlohmann-json: Install all the headers

  It turns out that it is necessary to ship all the headers if the
  JSON_MultipleHeaders option was used for building. Otherwise, even the most
  popular header, json.hpp, no longer works correctly.

  PR:		249895
  Approved by:	yuri@ (maintainer)

Changes:
  head/devel/nlohmann-json/Makefile
  head/devel/nlohmann-json/pkg-plist
Comment 9 Mateusz Piotrowski freebsd_committer freebsd_triage 2020-09-25 22:06:48 UTC 
Thanks again!