Bug 249981 - bhyve(8) man page -p option for virtual cpu pinning could be more helpful
Summary: bhyve(8) man page -p option for virtual cpu pinning could be more helpful
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Manual Pages (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords: easy, patch
Depends on:
Blocks:
 
Reported: 2020-09-29 09:23 UTC by Peter Grehan
Modified: 2023-10-09 16:36 UTC (History)
6 users (show)

See Also:


Attachments
bhyve(8) patch (551 bytes, patch)
2021-09-28 04:57 UTC, Felix Johnson
felix.the.red: maintainer-approval? (felix.the.red)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Grehan freebsd_committer freebsd_triage 2020-09-29 09:23:02 UTC
bz has some feedback that the '-p' option could have some additional text, and perhaps an example.

The text could say that the guest vCPUs are numbered from 0, as are host CPUs, and that a '-p' option is required for each guest vCPU that needs to be pinned.

For example, mapping a 4 vCPU guest to host CPUs 12-15 would require

  -p 0:12 -p 1:13 -p 2:14 -p 3:15
Comment 1 Felix Johnson 2021-09-28 04:57:12 UTC
Created attachment 228221 [details]
bhyve(8) patch

Expand -p option to include information about host and virtual CPU numbering, and that each pinned virtual CPU requires an additional -p invocation.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-10-09 16:35:32 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=8120190f80f2440e44615df85c64f1ea5aa97ddb

commit 8120190f80f2440e44615df85c64f1ea5aa97ddb
Author:     Felix Johnson <felix.the.red@gmail.com>
AuthorDate: 2023-10-09 16:32:33 +0000
Commit:     Benedict Reuschling <bcr@FreeBSD.org>
CommitDate: 2023-10-09 16:32:33 +0000

    bhyve(8): Expand the -p option text with additional text and an example

    PR:     249981

 usr.sbin/bhyve/bhyve.8 | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
Comment 3 Benedict Reuschling freebsd_committer freebsd_triage 2023-10-09 16:36:12 UTC
I've just committed the proposed patch. Thanks for submitting it! PR closed.