Comment 1 Fernando Apesteguía 2020-10-01 07:16:26 UTC

^Triage: Reporter is committer, assign accordingly.

^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.


Thanks!

Comment 2 Kenji Takefu 2020-10-10 03:01:16 UTC

Created attachment 218636 [details]
maradns-3.5.0017.patch

changelog:
https://maradns.samiam.org/changelog.html

maradns-3.5.0017:
This is a stable release of MaraDNS:

        coLunacyDNS update: We can now specify the “Authoritative” and “Recursion available” flags in the reply.
        coLunacyDNS update: We can now specify a TTL for the reply, to be anywhere from 0 seconds (do not cache) to a little over 90 days.
        coLunacyDNS version updated to be 1.0.009. 

    (2020-10-02)

Comment 3 Daniel Engberg 2023-06-03 18:58:06 UTC

Is still port still of interest, otherwise I'll deprecate it.

Comment 4 Kenji Takefu 2023-06-04 21:23:21 UTC

(In reply to Daniel Engberg from comment #3)


Right now I don't have permission to commit to the port tree.
So you can't move on to the next step.
An update to version 3.5.0036 is also coming soon.

Comment 5 Norikatsu Shigemura 2023-06-14 08:03:39 UTC

I'll handle this PR.  I contacted this maintainer, so requested by him.

Comment 6 Kenji Takefu 2023-06-14 21:46:12 UTC

Created attachment 242780 [details]
maradns-3.5.0036.patch

Update to 3.5.0036

https://maradns.samiam.org/changelog.html

Comment 7 Norikatsu Shigemura 2023-07-02 01:11:31 UTC

Created attachment 243114 [details]
I reviewed your patch, and feedback to you.

I reviewed your patch, so I found some problem:
  * portfmt not happy
  * portclippy not a little happy
    - portfmt and portclippy are conflicts a tab, so I divided sections.

You make some static patch in post-patch phase, but it's not good.
So I suggest that you recreate some patch files from some port-patch.

Comment 8 Kenji Takefu 2023-07-03 23:57:49 UTC

Created attachment 243193 [details]
maradns-3.5.0036.patch

Following some suggestions, INSTALL_PROGRAM was rewritten to reduce redundant STAGEDIR/PREFIX.
Static patches have been moved to files.
If this is good, please commit. :-)

Created attachment 245121 [details]
a new beta level patch

Hi Takefu.
Sorry too late, I reviewed your patch, so I found some problems.

* Remove make -> gmake patch
  Instead of gmake, I made a $WRKDIR/make in SUB_FILES.  So cleanup-ed post-patch phase.
  NOTE: In this time, I remained a debug code (-x flag).
* Some post-patch phase moved to files/patch-*

I found a compile error in server/MaraDNS.c.
- - - - - - - - - - - - - - - - - - - - - - - - -
MaraDNS.c:1153:39: error: use of undeclared identifier 'long_packet'
            if(check_ipv4_acl(ip_test,long_packet) == 1) {
                                      ^
1 error generated.
- - - - - - - - - - - - - - - - - - - - - - - - -

long_packet variable is defined in AUTHONLY macro.
So I don't have any idea to fix error, please fix it.

Comment 10 Kenji Takefu 2023-10-04 03:36:49 UTC

Created attachment 245424 [details]
maradns-3.5.0036.patch

It should work generally well.
The only thing is that IPv6 is not enabled, so I changed the MAKE variable.
Other 'chmod' has been replaced with a variable.
The only thing is that the presence or absence of the 'AUTHOLNY' macro does not affect the build.
Portlint, PortClippy compliance.

Created attachment 246129 [details]
maradns-3.5.0036.patch3

Thank you for your fix.  I confirmed OK.
But I found a issue to use $(CC) macros.  A Makefile doesn't use up $(M).
Please review my latest patch in your environment.

Comment 12 Kenji Takefu 2023-11-17 14:06:44 UTC

(In reply to Norikatsu Shigemura from comment #11)

thank you.
It works well in my environment.

Surely, other users will be happy :-)

Comment 13 Kenji Takefu 2024-02-05 05:31:21 UTC

Created attachment 248196 [details]
maradns-3.5.0036.patch4

fix
  bug #276551

Comment 14 Norikatsu Shigemura 2024-02-09 17:05:15 UTC

Created attachment 248288 [details]
maradns-3.5.0036.patch5

I and hrs (mentor) reviews your patch, so I feed-back to new patch as  maradns-3.5.0036.patch5.
So please review following changes:
- no longer use gmake.
- no need set explicitly OPTIONS (DOCS, EXAMPLES and IPV6).
- style (EXAMPLES and MANPAGES)
- no need explicitly @dir.

Comment 15 Kenji Takefu 2024-02-21 12:42:25 UTC

Created attachment 248656 [details]
maradns-3.5.0036.patch6

BUG #276551 Adaptation.
portclippy(1),portlint(1) Compliant.

Fixed duplicate path rewriting.
  patch-doc_en_examples_example__full__mararc