Bug 250045 - multimedia/libvpx: fix build on armv6/7
Summary: multimedia/libvpx: fix build on armv6/7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-02 07:37 UTC by Mikael Urankar
Modified: 2020-10-15 13:28 UTC (History)
1 user (show)

See Also:
jbeich: merge-quarterly+


Attachments
v1 (683 bytes, patch)
2020-10-02 07:37 UTC, Mikael Urankar
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer 2020-10-02 07:37:23 UTC
Created attachment 218464 [details]
v1

as -I./ -I"/wrkdirs/usr/ports/multimedia/libvpx/work/libvpx-1.9.0"/ -mfpu=neon -o vpx_dsp/arm/intrapred_neon_asm.asm.S.o vpx_dsp/arm/intrapred_neon_asm.asm.S
as -I./ -I"/wrkdirs/usr/ports/multimedia/libvpx/work/libvpx-1.9.0"/ -mfpu=neon -o vpx_dsp/arm/vpx_convolve_copy_neon_asm.asm.S.o vpx_dsp/arm/vpx_convolve_copy_neon_asm.asm.S
/bin/sh: as: not found


fwiw, nasm is not required on armv6/7/8
Comment 1 daniel.engberg.lists 2020-10-02 08:50:56 UTC
Style suggestion
https://github.com/freebsd/freebsd-ports/blob/master/multimedia/ffmpeg/Makefile#L20
Comment 2 commit-hook freebsd_committer 2020-10-15 13:27:15 UTC
A commit references this bug:

Author: jbeich
Date: Thu Oct 15 13:26:56 UTC 2020
New revision: 552412
URL: https://svnweb.freebsd.org/changeset/ports/552412

Log:
  multimedia/libvpx: unbreak armv6/armv7 on -CURRENT

  as -I./ -I"/wrkdirs/usr/ports/multimedia/libvpx/work/libvpx-1.9.0"/ -march=armv7-a -meabi=5 -mfpu=neon -o vpx_dsp/arm/vpx_convolve_copy_neon_asm.asm.S.o vpx_dsp/arm/vpx_convolve_copy_neon_asm.asm.S
  /bin/sh: as: not found

  PR:		250045
  Submitted by:	mikael (based on)

Changes:
  head/multimedia/libvpx/Makefile
Comment 3 commit-hook freebsd_committer 2020-10-15 13:28:17 UTC
A commit references this bug:

Author: jbeich
Date: Thu Oct 15 13:27:20 UTC 2020
New revision: 552413
URL: https://svnweb.freebsd.org/changeset/ports/552413

Log:
  MFH: r552412

  multimedia/libvpx: unbreak armv6/armv7 on -CURRENT

  as -I./ -I"/wrkdirs/usr/ports/multimedia/libvpx/work/libvpx-1.9.0"/ -march=armv7-a -meabi=5 -mfpu=neon -o vpx_dsp/arm/vpx_convolve_copy_neon_asm.asm.S.o vpx_dsp/arm/vpx_convolve_copy_neon_asm.asm.S
  /bin/sh: as: not found

  PR:		250045
  Submitted by:	mikael (based on)
  Approved by:	ports-secteam blanket

Changes:
_U  branches/2020Q4/
  branches/2020Q4/multimedia/libvpx/Makefile