Bug 250099 - net/frr7: small defect in the startup script
Summary: net/frr7: small defect in the startup script
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Olivier Cochard
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-04 17:25 UTC by Eugene Grosbein
Modified: 2020-10-05 07:49 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (olivier)
eugen: maintainer-feedback? (olivier)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Grosbein freebsd_committer freebsd_triage 2020-10-04 17:25:23 UTC 
Startup script of net/frr7 port contains unquoted call $(check_process ${command}) that may return a list, not single token only.

In such case, the test [ -z $(check_process ${command}) ]
emits syntax error similar to:

[: 1176: unexpected operator

It needs double quotes: [ -z "$(check_process ${command})" ]

Normally, this error should not happen unless there is unrelated process in the system selected by check_process subroutine in addition to one of frr's.
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-10-05 07:48:36 UTC 
A commit references this bug:

Author: olivier
Date: Mon Oct  5 07:48:18 UTC 2020
New revision: 551478
URL: https://svnweb.freebsd.org/changeset/ports/551478

Log:
  Harden RC script by adding double quotes.
  While here, document usage of frr_vtysh_boot.

  PR:		250099
  Submitted by:	eugen

Changes:
  head/net/frr7/Makefile
  head/net/frr7/files/frr.in
Comment 2 Olivier Cochard freebsd_committer freebsd_triage 2020-10-05 07:49:47 UTC 
Thanks Eugene!