Bug 250308 - [patch] Add support for VMware ESXi ARM Fling guest VM
Summary: [patch] Add support for VMware ESXi ARM Fling guest VM
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: conf (show other bugs)
Version: CURRENT
Hardware: arm64 Any
: --- Affects Some People
Assignee: Ed Maste
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-12 22:48 UTC by Vincent Milum Jr
Modified: 2023-05-23 19:24 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Milum Jr 2020-10-12 22:48:58 UTC 
Now that there is an ARM64 version of VMware, I've added several of the drivers from AMD64 GENERIC over to ARM64 GENERIC. These drivers all work out of the box, unmodified, under VMware ESXi ARM Fling.

Adding the following drivers for VMware virtual machines

vmx: vmxnet3 virtual network card
pvscsi: paravirtual scsi
uhci: USB 2.0 controller
ums: USB mouse

Diff:
https://patch-diff.githubusercontent.com/raw/freebsd/freebsd/pull/441.diff
Comment 1 Conrad Meyer freebsd_committer freebsd_triage 2020-10-12 23:47:36 UTC 
LGTM except for files.arm64 — those files should be moved into generic conf/files, assuming they're in files.x86 today.
Comment 2 Vincent Milum Jr 2020-10-13 03:03:33 UTC 
Right, I copied them from files.amd64 into files.arm64

If these should be in the main files (generic) instead of the arch specific files, I'll leave that up to the experts.

As of right now, VMware only supports i386, amd64, and arm64. There is no support for arm (32-bit), or the other platforms like mips, powerpc, or riscv.
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-10-15 14:38:31 UTC 
A commit references this bug:

Author: emaste
Date: Thu Oct 15 14:37:52 UTC 2020
New revision: 366726
URL: https://svnweb.freebsd.org/changeset/base/366726

Log:
  move vmware pv drivers to sys/conf/files

  VMware now has arm64 support; move these to MI files in advance of
  building them on arm64.

  PR:		250308
  Reported by:	Vincent Milum Jr
  MFC after:	1 week
  Sponsored by:	The FreeBSD Foundation

Changes:
  head/sys/conf/files
  head/sys/conf/files.amd64
  head/sys/conf/files.i386
Comment 4 Ed Maste freebsd_committer freebsd_triage 2020-10-15 14:46:32 UTC 
Is there no need for vmci on arm64?
Comment 5 commit-hook freebsd_committer freebsd_triage 2020-10-20 20:11:53 UTC 
A commit references this bug:

Author: emaste
Date: Tue Oct 20 20:11:29 UTC 2020
New revision: 366902
URL: https://svnweb.freebsd.org/changeset/base/366902

Log:
  arm64: add uhci to GENERIC

  uhci is (or, can be) used by VMware ESXi-Arm.

  PR:		250308
  Reported by:	Vincent Milum Jr
  MFC after:	2 weeks
  Sponsored by:	The FreeBSD Foundation

Changes:
  head/sys/arm64/conf/GENERIC
Comment 6 Vincent Milum Jr 2020-10-21 04:26:13 UTC 
"Is there no need for vmci on arm64?"

Me personally, I've never used an application that uses is on x86. Others might see it as useful? But when I was trying to compile it, I found a bunch of x86 ASM macros that I didn't feel like digging into at the time, so I've not gotten it working at all yet.
Comment 7 commit-hook freebsd_committer freebsd_triage 2020-11-03 01:38:43 UTC 
A commit references this bug:

Author: emaste
Date: Tue Nov  3 01:38:17 UTC 2020
New revision: 367289
URL: https://svnweb.freebsd.org/changeset/base/367289

Log:
  MFC r366902: arm64: add uhci to GENERIC

  uhci is (or, can be) used by VMware ESXi-Arm.

  PR:		250308
  Reported by:	Vincent Milum Jr
  Sponsored by:	The FreeBSD Foundation

Changes:
_U  stable/12/
  stable/12/sys/arm64/conf/GENERIC
Comment 8 Vincent Milum Jr 2023-05-23 19:24:00 UTC 
We've had this fixed for quite a while now! :)