When TLS_SRP is deselected, the following errors occur:
--- vtls/libcurl_la-openssl.lo ---
vtls/openssl.c:2475:57: error: no member named 'authtype' in 'struct ssl_config_data'
const enum CURL_TLSAUTH ssl_authtype = SSL_SET_OPTION(authtype);
vtls/vtls.h:133:41: note: expanded from macro 'SSL_SET_OPTION'
(SSL_IS_PROXY() ? data->set.proxy_ssl.var : data->set.ssl.var)
Similarly for username and password.
This is due to the the new ifdef in work/curl-7.73.0/lib/urldata.h
char *username; /* TLS username (for, e.g., SRP) */
char *password; /* TLS password (for, e.g., SRP) */
enum CURL_TLSAUTH authtype; /* TLS authentication type (default SRP) */
This is a new feature (wasn't a problem with 7.72) ;)
Commenting out the ifdef/endif enables 7.73 to build and function correctly.
FreeBSD 12.2-STABLE #0 r366190M: Mon Sep 28 03:58:09 AEST 2020 i386 1202502 1202502
(In reply to dewayne from comment #0)
Upstream has a patch to fix this. I'm testing it right now and if curl builds (and runs) without any issues I'll supply a patch.
Created attachment 218791 [details]
Fix building with OpenSSL (and TLS_SRP disabled)
Pulled in from upstream (PR 6094)
Builds and runs fine here now.
Patch works for me:
# curl --version
curl 7.73.0 (amd64-portbld-freebsd12.2) libcurl/7.73.0 OpenSSL/1.1.1g zlib/1.2.11 zstd/1.4.5 nghttp2/1.41.0
Protocols: file http https mqtt smtp smtps
Features: AsynchDNS GSS-API HTTP2 HTTPS-proxy IPv6 Kerberos Largefile libz SPNEGO SSL UnixSockets zstd
# uname -a
FreeBSD bsd1srv.fritz.box 12.2-STABLE FreeBSD 12.2-STABLE r365640 GENERIC amd64
(In reply to dewayne from comment #4)
The PR now has the status FIXED and CLOSED, but usually a port committer sets this once the patch has been comitted to the ports tree.
LGTM - poudriere OK on 12.2-RC3 amd64 & 13.0-CURRENT amd64
A commit references this bug:
Date: Sun Oct 18 15:37:30 UTC 2020
New revision: 552670
Fix build when TLS_SRP is disabled
Reported by: Dewayne Geraghty <email@example.com>
Obtained from: https://github.com/curl/curl/commit/a3d5b199f96a108f38bd1f6adaf3a7585f721d02