Bug 250432 - devel/rubygem-rb-kqueue: Apply a patch fixing a bug which break Jekyll live reload
Summary: devel/rubygem-rb-kqueue: Apply a patch fixing a bug which break Jekyll live r...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mateusz Piotrowski
URL: https://github.com/mat813/rb-kqueue/p...
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2020-10-18 11:01 UTC by Mateusz Piotrowski
Modified: 2020-11-02 00:25 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
Patch (1.01 KB, patch)
2020-10-18 11:01 UTC, Mateusz Piotrowski 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mateusz Piotrowski freebsd_committer freebsd_triage 2020-10-18 11:01:16 UTC 
Created attachment 218858 [details]
Patch

When running jekyll --livereload I experience the following problems:

> #<Thread:0x0000000805153558@/usr/local/lib/ruby/gems/2.6/gems/listen-3.2.1/lib/listen/internals/thread_pool.rb:6 run> terminated with exception (report_on_exception is true):
> Traceback (most recent call last):
>         7: from /usr/local/lib/ruby/gems/2.6/gems/listen-3.2.1/lib/listen/internals/thread_pool.rb:6:in `block in add'
>         6: from /usr/local/lib/ruby/gems/2.6/gems/listen-3.2.1/lib/listen/adapter/base.rb:78:in `block in start'
>         5: from /usr/local/lib/ruby/gems/2.6/gems/listen-3.2.1/lib/listen/adapter/bsd.rb:50:in `_run'
>         4: from /usr/local/lib/ruby/gems/2.6/gems/rb-kqueue-0.2.5/lib/rb-kqueue/queue.rb:316:in `run'
>         3: from /usr/local/lib/ruby/gems/2.6/gems/rb-kqueue-0.2.5/lib/rb-kqueue/queue.rb:337:in `process'
>         2: from /usr/local/lib/ruby/gems/2.6/gems/rb-kqueue-0.2.5/lib/rb-kqueue/queue.rb:337:in `each'
>         1: from /usr/local/lib/ruby/gems/2.6/gems/rb-kqueue-0.2.5/lib/rb-kqueue/queue.rb:337:in `block in process'
> /usr/local/lib/ruby/gems/2.6/gems/rb-kqueue-0.2.5/lib/rb-kqueue/event.rb:80:in `callback!': undefined method `callback!' for nil:NilClass (NoMethodError)

It turns out that the patch from this PR (https://github.com/mat813/rb-kqueue/pull/12) fixes the issue.

I'm attaching a patch which adds the patch from the PR to the makefile.
Comment 1 Automation User 2020-11-02 00:07:59 UTC 
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/210370616
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-11-02 00:24:13 UTC 
A commit references this bug:

Author: 0mp
Date: Mon Nov  2 00:23:36 UTC 2020
New revision: 553878
URL: https://svnweb.freebsd.org/changeset/ports/553878

Log:
  Get the patch which fixes the --livereload flag

  Otherwise, Jekyll fails with the following error:

  /usr/local/lib/ruby/gems/2.6/gems/rb-kqueue-0.2.5/lib/rb-kqueue/event.rb:80:in `callback!': undefined method `callback!' for nil:NilClass (NoMethodError)

  PR:		250432
  Approved by:	maintainer timeout
  MFH:		2020Q4 (runtime fix)

Changes:
  head/devel/rubygem-rb-kqueue/Makefile
  head/devel/rubygem-rb-kqueue/distinfo
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-11-02 00:25:14 UTC 
A commit references this bug:

Author: 0mp
Date: Mon Nov  2 00:24:54 UTC 2020
New revision: 553879
URL: https://svnweb.freebsd.org/changeset/ports/553879

Log:
  MFH: r553878

  Get the patch which fixes the --livereload flag

  Otherwise, Jekyll fails with the following error:

  /usr/local/lib/ruby/gems/2.6/gems/rb-kqueue-0.2.5/lib/rb-kqueue/event.rb:80:in `callback!': undefined method `callback!' for nil:NilClass (NoMethodError)

  PR:		250432
  Approved by:	maintainer timeout

  Approved by:	portmgr (runtime fix blanket)

Changes:
_U  branches/2020Q4/
  branches/2020Q4/devel/rubygem-rb-kqueue/Makefile
  branches/2020Q4/devel/rubygem-rb-kqueue/distinfo