Created attachment 218934 [details]
Feel free to submit upstream if you have signed the CLA. I do not want to sign it.
Upstream bug https://bugs.launchpad.net/cloud-init/+bug/1901958
And I'm find bug parsing newfs option
if fs have trim: (-t) or MAC multilabel: (-l) flag, resize FS fail.
2020-10-28 17:15:07,015 - handlers.py[DEBUG]: finish: init-network/config-resizefs: FAIL: running config-resizefs with frequency always
File "/usr/local/lib/python3.7/site-packages/cloudinit/config/cc_resizefs.py", line 114, in _can_skip_resize_ufs
optlist, _args = getopt.getopt(newfs_cmd[1:], opt_value)
File "/usr/local/lib/python3.7/getopt.py", line 95, in getopt
opts, args = do_shorts(opts, args[1:], shortopts, args[1:])
File "/usr/local/lib/python3.7/getopt.py", line 195, in do_shorts
if short_has_arg(opt, shortopts):
File "/usr/local/lib/python3.7/getopt.py", line 211, in short_has_arg
raise GetoptError(_('option -%s not recognized') % opt, opt)
getopt.GetoptError: option -t not recognized
And fix #Bug250437 (delet dependency py-six) upstream drop this 20.2 https://github.com/number5/cloud-init/commit/b9ff0dc950558ecd2a8469eded26bd6ae4082771
Created attachment 219185 [details]
I'm not sure this portion of your patch makes sense, because the criteria is coming from outside the function
- elif criteria == "TYPE=vfat":
+ elif criteria == "TYPE=msdosfs":
so vfat is the clue, and then we go looking for msdos or msdosfs
n.b.: i have signed a CLA, and submitted 75% of the recent FreeBSD patches to cloud-init: https://github.com/canonical/cloud-init/pulls?q=is%3Apr+author%3Aigalic
Created attachment 219195 [details]
Delete criteria section
Created attachment 219199 [details]
sync upstream https://github.com/canonical/cloud-init/pull/637
Fix mounting of vfat
A commit references this bug:
Date: Fri Oct 30 09:58:48 UTC 2020
New revision: 553676
- Amend the list of recognized newfs(8) options
- Fix mounting of VFAT which FreeBSD calls "msdos[fs]"
- GC `devel/py-six' dependency, unused since v20.2
Committed as ports r553676, thank you all.
Thank you all!