Bug 250706 - lib.libc.ssp.ssp_test.raw is broken without ASAN
Summary: lib.libc.ssp.ssp_test.raw is broken without ASAN
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: tests (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-testing (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-28 23:10 UTC by Brooks Davis
Modified: 2024-11-02 16:42 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brooks Davis freebsd_committer freebsd_triage 2020-10-28 23:10:34 UTC 
The raw SSP test is broken without ASAN.  Unfortunately, we can not reliably link ASAN support code in an external cross compiler (it might be for a newer OS version and require new syscalls).  We need to be linking against an ASAN library matching the version of FreeBSD being built.
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-10-28 23:10:57 UTC 
A commit references this bug:

Author: brooks
Date: Wed Oct 28 23:10:55 UTC 2020
New revision: 367121
URL: https://svnweb.freebsd.org/changeset/base/367121

Log:
  Disable ssp raw test without ASAN

  r366981 disabled ASAN when it might not be reliable (with an external
  compiler), but this test is broken without ASAN so disable it completely
  in that case.

  PR:		250706
  Reviewed by:	emaste, lwhsu
  Differential Revision:	https://reviews.freebsd.org/D26982

Changes:
  head/lib/libc/tests/ssp/Makefile
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-11-03 23:29:47 UTC 
A commit references this bug:

Author: brooks
Date: Tue Nov  3 23:29:08 UTC 2020
New revision: 367314
URL: https://svnweb.freebsd.org/changeset/base/367314

Log:
  MFC r367121:

  Disable ssp raw test without ASAN

  r366981 disabled ASAN when it might not be reliable (with an external
  compiler), but this test is broken without ASAN so disable it completely
  in that case.

  PR:		250706
  Reviewed by:	emaste, lwhsu
  Differential Revision:	https://reviews.freebsd.org/D26982

Changes:
_U  stable/12/
  stable/12/lib/libc/tests/ssp/Makefile
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-11-03 23:30:49 UTC 
A commit references this bug:

Author: brooks
Date: Tue Nov  3 23:30:12 UTC 2020
New revision: 367315
URL: https://svnweb.freebsd.org/changeset/base/367315

Log:
  MFC r367121:

  Disable ssp raw test without ASAN

  r366981 disabled ASAN when it might not be reliable (with an external
  compiler), but this test is broken without ASAN so disable it completely
  in that case.

  PR:		250706
  Reviewed by:	emaste, lwhsu
  Differential Revision:	https://reviews.freebsd.org/D26982

Changes:
_U  stable/11/
  stable/11/lib/libc/tests/ssp/Makefile