Bug 250744 - [NEW PORT]: databases/xtrabackup8
Summary: [NEW PORT]: databases/xtrabackup8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-30 20:23 UTC by Eugene M. Zheganin
Modified: 2020-11-07 05:51 UTC (History)
2 users (show)

See Also:


Attachments
port gzipped shar archive (1.22 KB, application/x-gzip)
2020-10-30 20:23 UTC, Eugene M. Zheganin
no flags Details
updated port shar archive (2.56 KB, text/plain)
2020-10-31 20:33 UTC, Eugene M. Zheganin
no flags Details
pkgconf patch (424 bytes, patch)
2020-11-07 04:29 UTC, Eugene M. Zheganin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene M. Zheganin 2020-10-30 20:23:54 UTC
Created attachment 219225 [details]
port gzipped shar archive

Don't know why we still don't have an xtrabackup 8.x port, here's my attempt to fix this: existing port is suitable only for databases/mysql5[5-7]-server instances, this port is intended to use with databases/mysql80-server instances (which xtrabackup 2.4.x is incompatible with).

Please review and add appropriate notes or commit this into the ports tree.

Since I'm not enthusiastic at all about maintaining this port (just trying to do my part), if samm@ wants he can take it. If not, I can be the maintainer.
Comment 1 Kurt Jaeger freebsd_committer 2020-10-31 18:08:23 UTC
Can you test the port with portlint -AC ? It throws an awful lot of errors.
Comment 2 Eugene M. Zheganin 2020-10-31 20:32:13 UTC
Only one error, the rest are warning - but okay: here's the updated version.
It only blames NLS now, but I truly believe this port doesn't need NLS in any form.
Comment 3 Eugene M. Zheganin 2020-10-31 20:33:02 UTC
Created attachment 219264 [details]
updated port shar archive

with minimal portlint warnings.
Comment 4 Kurt Jaeger freebsd_committer 2020-11-06 19:28:21 UTC
Surprisingly, it fails in poudriere. Did you test with poudriere or did I do something wrong ?

https://people.freebsd.org/~pi/logs/databases__xtrabackup8-122-1604176468.txt
Comment 5 commit-hook freebsd_committer 2020-11-06 20:38:07 UTC
A commit references this bug:

Author: danfe
Date: Fri Nov  6 20:37:48 UTC 2020
New revision: 554316
URL: https://svnweb.freebsd.org/changeset/ports/554316

Log:
  Split `databases/xtrabackup8', based on 8.x versions, which is intended
  to be used against `databases/mysql80-server', which versions 2.4.x are
  incompatible with.

  PR:	250744

Changes:
  head/databases/Makefile
  head/databases/xtrabackup8/
  head/databases/xtrabackup8/Makefile
  head/databases/xtrabackup8/distinfo
  head/databases/xtrabackup8/files/patch-cmake_os_FreeBSD.cmake
  head/databases/xtrabackup8/files/patch-sql_binlog.cc
  head/databases/xtrabackup8/files/patch-storage-myisam-mi_dynrec.c
  head/databases/xtrabackup8/files/patch-storage_innobase_xtrabackup_xbcloud__osenv.sh
  head/databases/xtrabackup8/pkg-descr
  head/databases/xtrabackup8/pkg-plist
Comment 6 Alexey Dokuchaev freebsd_committer 2020-11-06 20:48:18 UTC
(In reply to Kurt Jaeger from comment #4)
> Surprisingly, it fails in poudriere.
Of couse it fails, it was nowhere near being ready.  Submitter asked me if I could help him out, which I hopefully did with ports r554316.
Comment 7 Eugene M. Zheganin 2020-11-07 04:29:01 UTC
Created attachment 219416 [details]
pkgconf patch

patch fixing the devel/pkgconf dependency.
Comment 8 Alexey Dokuchaev freebsd_committer 2020-11-07 05:51:13 UTC
(In reply to Eugene M. Zheganin from comment #7)
> patch fixing the devel/pkgconf dependency.
There's nothing to fix, pkgconf(1) dependency is handled via USES+=pkgconfig.