Bug 250849 - ports-mgmt/portshaker: use either subversion 1.14 or LTS depending on make.conf variable
Summary: ports-mgmt/portshaker: use either subversion 1.14 or LTS depending on make.co...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Romain Tartière
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2020-11-04 03:37 UTC by Norikatsu Shigemura
Modified: 2020-12-14 02:20 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (romain)

Attachments
Respect WITH_SUBVERSION_VER (574 bytes, patch)
2020-11-04 03:37 UTC, Norikatsu Shigemura 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Norikatsu Shigemura 2020-11-04 03:37:33 UTC 
Created attachment 219344 [details]
Respect WITH_SUBVERSION_VER

Respect WITH_SUBVERSION_VER.
Comment 1 Automation User 2020-11-19 01:03:07 UTC 
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/218208041
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-12-14 02:19:17 UTC 
A commit references this bug:

Author: romain
Date: Mon Dec 14 02:18:53 UTC 2020
New revision: 558072
URL: https://svnweb.freebsd.org/changeset/ports/558072

Log:
  Fix usage of WITH_SUBVERSION_VER

  devel/subversion used to be available in different versions from which the
  end-user could choose by setting WITH_SUBVERSION_VER to the expected version.
  This has been reworked at some point and broke that feature in portshaker.

  Adjust the WITH_SUBVERSION_VER handling to cope with it again.

  PR:		250849
  Submitted by:	nork@ninth-nine.com

Changes:
  head/ports-mgmt/portshaker/Makefile
Comment 3 Romain Tartière freebsd_committer freebsd_triage 2020-12-14 02:20:09 UTC 
Hello, thank you for this PR.  I am sorry to only take the time to dig in this today, thank you for the great work!