Bug 251059 - www/gstreamer1-plugins-neon - Missing ne_session.h -- looking in wrong place?
Summary: www/gstreamer1-plugins-neon - Missing ne_session.h -- looking in wrong place?
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-multimedia (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-11 22:41 UTC by break19
Modified: 2020-11-14 16:23 UTC (History)
2 users (show)

See Also:
tcberner: maintainer-feedback+

Attachments
poudriere log for failed build (76.77 KB, text/plain)
2020-11-11 22:41 UTC, break19 		no flags Details
v1 (576 bytes, patch)
2020-11-12 05:48 UTC, Tobias C. Berner 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description break19 2020-11-11 22:41:53 UTC 
Created attachment 219578 [details]
poudriere log for failed build

In file included from gstneonhttpsrc.c:21:
./gstneonhttpsrc.h:26:10: fatal error: 'ne_session.h' file not found
#include <ne_session.h>
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2020-11-12 05:36:50 UTC 
Moin moin 

This was caused by the update of www/neon from pr250048 to 0.31.x, as the configure script of this port does a call: 
> pkg-config --exists --print-errors "neon >= 0.27.0  neon <= 0.30.99" 
Package dependency requirement 'neon <= 0.30.99' could not be satisfied.
Package 'neon' has version '0.31.2', required version is '<= 0.30.99'

So most likely it can easily be fixed by removing the upper bound of the check.


mfg Tobias
Comment 2 Tobias C. Berner freebsd_committer freebsd_triage 2020-11-12 05:48:41 UTC 
Created attachment 219581 [details]
v1

Moin moin 

try this patch please.


mfg Tobias
Comment 3 break19 2020-11-14 12:39:33 UTC 
That seems to work! Now to push it out?
Comment 4 Niko 2020-11-14 14:16:26 UTC 
make[2]: "/usr/ports/www/gstreamer1-plugins-neon/../../multimedia/gstreamer1-plugins/Makefile" line 144: Need an operator
make[2]: Fatal errors encountered -- cannot continue

patch was a good effort, but still
Comment 5 Niko 2020-11-14 14:17:11 UTC 
(In reply to Tobias C. Berner from comment #2)
make[2]: "/usr/ports/www/gstreamer1-plugins-neon/../../multimedia/gstreamer1-plugins/Makefile" line 144: Need an operator
make[2]: Fatal errors encountered -- cannot continue
Comment 6 Niko 2020-11-14 14:23:15 UTC 
(In reply to Niko from comment #5)
Removed: # Fix dependency on neon-0.31
somehow it did not honor the # comment symbol! so to hell with it deleted the comment and now it works
Comment 7 break19 2020-11-14 15:00:41 UTC 
(In reply to Niko from comment #6)
Odd. I had no such issues, but i patched manually, via copy/paste sooo.
Comment 8 commit-hook freebsd_committer freebsd_triage 2020-11-14 16:21:15 UTC 
A commit references this bug:

Author: tcberner
Date: Sat Nov 14 16:20:45 UTC 2020
New revision: 555120
URL: https://svnweb.freebsd.org/changeset/ports/555120

Log:
  www/gstreamer1-plugins-neon: fix build with neon 0.31

  PR:		251059
  PR:		250048
  Reported by:	break19@gmail.com

Changes:
  head/multimedia/gstreamer1-plugins/Makefile