Bug 251235 - net/py-urllib3: Update to 1.26.2
Summary: net/py-urllib3: Update to 1.26.2
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-python (Nobody)
URL: https://github.com/urllib3/urllib3/re...
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2020-11-18 09:48 UTC by daniel.engberg.lists
Modified: 2021-03-18 18:48 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (python)
koobs: merge-quarterly?


Attachments
Patch for urllib3 (825 bytes, patch)
2020-11-18 09:48 UTC, daniel.engberg.lists
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description daniel.engberg.lists 2020-11-18 09:48:59 UTC
Created attachment 219788 [details]
Patch for urllib3

Update (py-)urllib3 to 1.26.2

FreeBSD 13.0-CURRENT r367711 amd64 (make, make check-plist, make test)
Poudriere testport OK 12.2-RELEASE (amd64)
Poudriere testport OK 11.4-RELEASE (amd64)

One test fails on both 1.25.11 and 1.26.2

test/contrib/test_socks.py::TestSocks5Proxy::test_socks_with_invalid_password FAILED
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2020-12-01 01:39:21 UTC
Thank you for the patch Daniel

How does QA go with all dependent ports and www/py-requests in particular?

See ports r490937 and ports r517078 for examples of potential issues

Please also detail MFH: <branch|no> <reason> with respect to the version delta in the patch, and considering the bugfixes contained between those versions
Comment 2 daniel.engberg.lists 2021-03-18 14:23:35 UTC
Closing this as I don't have the ability to test this within a foreseeable future
Comment 3 Steve Wills freebsd_committer 2021-03-18 18:48:45 UTC
(In reply to daniel.engberg.lists from comment #2)

I think the version of requests currently in the tree is going to break:

https://github.com/psf/requests/blob/v2.22.0/setup.py#L47

but the latest version should be fine:

https://github.com/psf/requests/blob/v2.25.1/setup.py#L47

Doing run time testing on all the things that depend on both of them is probably not feasible.