Bug 251268 - net/geoipupdate: switch to USES=go:modules
Summary: net/geoipupdate: switch to USES=go:modules
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Adam Weinberger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-20 12:17 UTC by Dmitri Goutnik
Modified: 2020-11-22 22:40 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (adamw)
dmgk: maintainer-feedback?


Attachments
patch file (5.20 KB, patch)
2020-11-20 12:17 UTC, Dmitri Goutnik
adamw: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer 2020-11-20 12:17:10 UTC
Created attachment 219827 [details]
patch file

Switch to USES=go:modules and pass GO_ENV down to make in preparation for the upcoming go1.16 release.

Builds fine on 12.2-RELEASE amd64 with both current lang/go 1.15.5 and lang/go-devel@399b5d14d411
Comment 1 Adam Weinberger freebsd_committer 2020-11-22 16:08:09 UTC
Comment on attachment 219827 [details]
patch file

This is great! Thanks for your help on these updates, Dmitri.

While I appreciate the thoughtfulness of a PR, you definitely don't need to submit them for anything I maintain. I fully trust your judgment, so please feel free to commit stuff like this anytime.
Comment 2 commit-hook freebsd_committer 2020-11-22 22:39:54 UTC
A commit references this bug:

Author: dmgk
Date: Sun Nov 22 22:39:02 UTC 2020
New revision: 556077
URL: https://svnweb.freebsd.org/changeset/ports/556077

Log:
  net/geoipupdate: switch to USES=go:modules

  Switch to USES=go:modules and pass GO_ENV down to make in preparation for the
  upcoming go1.16 release.

  PR:		251268
  Approved by:	adamw (maintainer)

Changes:
  head/net/geoipupdate/Makefile
  head/net/geoipupdate/distinfo
  head/net/geoipupdate/files/patch-Makefile
Comment 3 Dmitri Goutnik freebsd_committer 2020-11-22 22:40:22 UTC
Committed, thanks for the (blanket) approval, Adam.