Bug 251534 - devel/nspr: allow build on riscv64
Summary: devel/nspr: allow build on riscv64
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gecko (Nobody)
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2020-12-02 16:17 UTC by Mark Linimon
Modified: 2021-01-02 00:35 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (gecko)


Attachments
patch to files/patch-pr_include_md___freebsd.cfg (575 bytes, patch)
2020-12-02 16:17 UTC, Mark Linimon
no flags Details | Diff
new file files/patch-pr_include_md___freebsd.h (575 bytes, patch)
2020-12-02 16:19 UTC, Mark Linimon
no flags Details | Diff
patch to files/patch-pr_include_md___freebsd.cfg (3.18 KB, patch)
2020-12-02 16:20 UTC, Mark Linimon
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Linimon freebsd_committer freebsd_triage 2020-12-02 16:17:31 UTC
Created attachment 220174 [details]
patch to files/patch-pr_include_md___freebsd.cfg

These patches allow devel/nspr to build on riscv64 (at least, under qemu).

The stanzas are naively taken from the linux equivalents.

Patched:

  files/patch-pr_include_md___freebsd.cfg

New file:

  files/patch-pr_include_md___freebsd.h
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2020-12-02 16:19:52 UTC
Created attachment 220175 [details]
new file files/patch-pr_include_md___freebsd.h
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2020-12-02 16:20:32 UTC
Created attachment 220176 [details]
patch to files/patch-pr_include_md___freebsd.cfg
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2020-12-02 17:02:04 UTC
fwiw, if accepted, these changes will need to be upstreamed.
Comment 4 Jan Beich freebsd_committer 2020-12-02 17:59:14 UTC
(In reply to Mark Linimon from comment #3)
> fwiw, if accepted, these changes will need to be upstreamed.

This is backwards. I'm usually very reluctant to approve anything not submitted upstream, often leaving for "maintainer timeout". Whatever already landed upstream is covered by "portmgr blanket", so one can avoid wasting their and maintainer's time on rubberstamps.

Please, rename the patch file after upstream bug. This is important in order to safely prune patches on NSPR updates.
Comment 5 Automation User 2020-12-17 00:12:07 UTC
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/231032415
Comment 6 Mark Linimon freebsd_committer freebsd_triage 2021-01-01 23:33:04 UTC
(In reply to Jan Beich from comment #4)

The pkg-descr is out of date, so you will have to tell me where the project has moved to, so I can submit the patch upstream.
Comment 8 commit-hook freebsd_committer 2021-01-02 00:35:59 UTC
A commit references this bug:

Author: jbeich
Date: Sat Jan  2 00:35:06 UTC 2021
New revision: 559898
URL: https://svnweb.freebsd.org/changeset/ports/559898

Log:
  devel/nspr: chase homepage

  Sorry, the page /en-US/docs/NSPR could not be found.

  PR:		251534
  Reported by:	linimon

Changes:
  head/devel/nspr/pkg-descr