Some things have happened since 17.8.0 in treq: - New upstream maintainers - Numerous bug fixes, including a few annoying URL encoding issues - Official python 3.7 support - Official python 3.8 support Incoming patch also fixes the test suite, which (possibly) last worked with 17.3.1.
Created attachment 220557 [details] py-treq_20.9.0
Forgot to mention, this port is used extensively by net-im/py-matrix-synapse.
LGTM!
Created attachment 221003 [details] py-treq_20.9.0 (test dep: www/py-httpbin) After some feedback on #251847, the new port will be www/py-httpbin (and not devel/py-httpbin). Further reporting that no negative impact has been noticed on net-im/py-matrix-synapse running against this treq version.
I briefly want to update this issue in light of 255547: I've built and tested the port against the update py-twisted port, and the testsuite passes without any issues. It also works perfectly with py-matrix-synapse (and the updated py-twisted) in production. Can we perhaps get this merged or is there anything else blocking this?
(In reply to Sascha Biberhofer from comment #5) The only thing left, Sascha, is to get approval to merge it. I'm seeking that now. However, there's one other thing. py-treq is apparently used extensively by net-im/py-matrix-synapse, which you maintain. I no longer use any software that depends on py-treq. Would you like to take over maintainership?
Hey Alan, original reporter here. Just talked with Sascha off bugzilla as we do occasionally to share/test patches; and he mentioned a time limitation regarding adopting this port. Since I follow Twisted and klein's development closely, I wouldn't mind adopting those ports if you are unable to or need some offloading. Possibly this would mean that Sascha and I can coordinate to keep these ports up to date and better supported and share the load when we need it. Cheers,
(In reply to Evilham from comment #7) Sure, Evilham. You could probably do a better job than I. I'll assign you maintainership after I get this patch committed.
(In reply to Alan Somers from comment #6) Approved by: kevans (ports)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=cd62f0886c18589e2274029d48efa10d57a5531a commit cd62f0886c18589e2274029d48efa10d57a5531a Author: Alan Somers <asomers@FreeBSD.org> AuthorDate: 2021-05-06 00:59:40 +0000 Commit: Alan Somers <asomers@FreeBSD.org> CommitDate: 2021-05-06 00:59:40 +0000 www/py-treq: Update to 20.9.0 Reported-by: evilham <contact@evilham.com> Approved-by: kevans (ports) PR: 251848 www/py-treq/Makefile | 12 +++++++----- www/py-treq/distinfo | 6 +++--- 2 files changed, 10 insertions(+), 8 deletions(-)
I committed it, and I also transferred maintainership to you, Evilham.