Bug 252190 - [NEW PORT] emulators/libretro-bsnes: Standalone port of bSNES 2014 (performance) to libretro emulator
Summary: [NEW PORT] emulators/libretro-bsnes: Standalone port of bSNES 2014 (performan...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Li-Wen Hsu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-27 06:40 UTC by Timothy Beyer
Modified: 2022-06-27 07:05 UTC (History)
4 users (show)

See Also:


Attachments
emulators_libretro-bsnes.shar (1.96 KB, text/plain)
2020-12-27 06:40 UTC, Timothy Beyer
no flags Details
emulators_libretro-bsnes.diff (2.14 KB, patch)
2021-12-22 10:03 UTC, Timothy Beyer
no flags Details | Diff
[PATCH / NEW PORT] emulators_libretro-bsnes.diff (fix build, build with poudriere) (2.09 KB, patch)
2022-05-17 05:55 UTC, Timothy Beyer
beyert: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Beyer 2020-12-27 06:40:19 UTC
Created attachment 220982 [details]
emulators_libretro-bsnes.shar

Created new port for BSNES libretro core, which has slightly better compatibility than the BSNES core in Mednafen for retroarch (see. Rudra no Hihou)

Tested with Retroarch 1.9.0 on FreeBSD 12.1-RELEASE:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252189
Comment 1 Daniel Menelkir 2021-07-07 12:26:15 UTC
Any progress on this?
Comment 2 Timothy Beyer 2021-07-14 07:22:03 UTC
(In reply to Daniel Menelkir from comment #1)
It is working for me, but let me know if it doesn't compile.
Comment 3 Daniel Menelkir 2021-07-14 13:11:07 UTC
(In reply to Timothy Beyer from comment #2)
It was more like a friendly ping, since most of libretro stuff is frozen here.
Comment 4 Timothy Beyer 2021-07-15 03:57:13 UTC
(In reply to Daniel Menelkir from comment #3)
much appreciated, cheers!
Comment 5 Max Brazhnikov freebsd_committer freebsd_triage 2021-07-15 09:15:11 UTC
Sorry, I forgot about these PRs, but I don't have time for them right now.
Comment 6 Li-Wen Hsu freebsd_committer freebsd_triage 2021-12-21 12:55:46 UTC
Doesn't work for me in 13.0-R poudriere:
https://gist.github.com/lwhsu/9e404fddf2c8549ed32d49da002e7bfb

Did I miss anything?
Comment 7 Timothy Beyer 2021-12-22 09:21:13 UTC
(In reply to Li-Wen Hsu from comment #6)
I think it has an issue with FreeBSD 13.0-RELEASE, as I only had access to 12.1-RELEASE at the time I originally submitted the patch.  I'm trying the current revision to see if that helps, but so far, it looks like some changes may be needed.

I will submit a patch to address any issues shortly.
Comment 8 Timothy Beyer 2021-12-22 10:03:38 UTC
Created attachment 230309 [details]
emulators_libretro-bsnes.diff

*  Fixes build on FreeBSD 13.0-RELEASE and newer by switching to g++:

   It is likely possible to get it working on clang++ again, but based on my research, it sounds like the current standard library and more recent versions of clang++ aren't working together properly, so when I can resolve that issue, I will remove the USE_GCC again.

   Updated to latest git revision, which is a bit more modern

   Minor adjustments

See emulators_libretro-bsnes.diff for more details
Comment 9 Timothy Beyer 2022-05-17 05:55:32 UTC
Created attachment 233995 [details]
[PATCH / NEW PORT] emulators_libretro-bsnes.diff (fix build, build with poudriere)

This is a higher quality git-formatted patch that was tested with poudriere, fixing any issues with the prior submission.

To clarify, note that this is actually a different emulator core than libretro's beetle snes in emulators/libretro-beetle_bsnes, with different advantages and tradeoffs.  Neither core is necessarily better, but the compatibility varied on a few games at least at the time when I originally made this port.

This submission should be ready to commit now, sorry about the prior missing dependencies.
Comment 10 commit-hook freebsd_committer freebsd_triage 2022-06-27 07:05:13 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bf58926b4a0215e065e097cd24654587bfae1f19

commit bf58926b4a0215e065e097cd24654587bfae1f19
Author:     Timothy Beyer <beyert@cs.ucr.edu>
AuthorDate: 2022-06-27 07:03:15 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2022-06-27 07:04:03 +0000

    Add emulators/libretro-bsnes

    Standalone port of bSNES 2014 (performance) to libretro emulator

    PR:             252190

 emulators/Makefile                       |  1 +
 emulators/libretro-bsnes/Makefile (new)  | 29 +++++++++++++++++++++++++++++
 emulators/libretro-bsnes/distinfo (new)  |  3 +++
 emulators/libretro-bsnes/pkg-descr (new) |  3 +++
 4 files changed, 36 insertions(+)