Bug 252257 - textproc/mgdiff: fix the build on -CURRENT
Summary: textproc/mgdiff: fix the build on -CURRENT
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kyle Evans
URL:
Keywords:
Depends on:
Blocks: 252245
  Show dependency treegraph
 
Reported: 2020-12-29 05:58 UTC by Kyle Evans
Modified: 2021-01-10 17:48 UTC (History)
2 users (show)

See Also:
portmaster: maintainer-feedback+


Attachments
git(1) diff against the ports tree (697 bytes, patch)
2020-12-29 05:58 UTC, Kyle Evans
no flags Details | Diff
svn diff for textproc/mgdiff version 2 (update to previous) (309 bytes, patch)
2020-12-30 21:42 UTC, Chris Hutchinson
portmaster: maintainer-approval+
Details | Diff
svn diff for textproc/mgdiff version 3 (fix against version 2) (309 bytes, patch)
2020-12-30 21:46 UTC, Chris Hutchinson
portmaster: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Evans freebsd_committer 2020-12-29 05:58:32 UTC
Created attachment 221076 [details]
git(1) diff against the ports tree

libgnuregex has been removed in -CURRENT. Switch to using the newer version that's provided in ports as of ports r559542.
Comment 1 Chris Hutchinson 2020-12-29 07:15:47 UTC
Comment on attachment 221076 [details]
git(1) diff against the ports tree

Approved.
Thanks, Kyle!
Comment 2 Fernando Apesteguía freebsd_committer 2020-12-30 18:30:11 UTC
^Triage: Reporter is committer, assign accordingly.

Q/A: 
 Makefile: LIB_DEPENDS don't specify the ABI version number .6 in libgnuregex.so.6 unless it is really necessary.
 Makefile: LIB_DEPENDS the new format is libFOO.so (e.g., liblibgnuregex.so.6.so).
Comment 3 Chris Hutchinson 2020-12-30 21:27:46 UTC
(In reply to Fernando Apesteguía from comment #2)
I'll address your concerns with a new patch shortly.
Comment 4 Chris Hutchinson 2020-12-30 21:42:56 UTC
Created attachment 221112 [details]
svn diff for textproc/mgdiff version 2 (update to previous)

This is an update to address comment #2
Comment 5 Chris Hutchinson 2020-12-30 21:46:41 UTC
Created attachment 221113 [details]
svn diff for textproc/mgdiff version 3 (fix against version 2)

OOPS!
Please use this one instead.
Comment 6 Kyle Evans freebsd_committer 2021-01-10 17:48:57 UTC
Same as on PR 252258; LIB_DEPENDS apparently cannot cope with pkgname>0 style test.