Bug 252456 - archivers/libzip: update to 1.7.3
Summary: archivers/libzip: update to 1.7.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dima Panov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-06 00:25 UTC by Dima Panov
Modified: 2021-01-07 10:16 UTC (History)
1 user (show)

See Also:
rakuco: maintainer-feedback+

Attachments
archivers/libzip: update to 1.7.3 (3.31 KB, patch)
2021-01-06 00:25 UTC, Dima Panov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dima Panov freebsd_committer freebsd_triage 2021-01-06 00:25:43 UTC 
Created attachment 221311 [details]
archivers/libzip: update to 1.7.3
Comment 1 Raphael Kubo da Costa freebsd_committer freebsd_triage 2021-01-06 11:31:53 UTC 
> +-if(NOT CMAKE_SYSTEM_NAME MATCHES Linux)
>  +IF(NOT CMAKE_SYSTEM_NAME MATCHES "FreeBSD|Linux")

Can you keep the `if` there in lowercase?

The change itself looks fine to me, but looking at libzip's commit history I can see lots of changes related to the build system, so I'd be more comfortable approving this after an exp-run.
Comment 2 Dima Panov freebsd_committer freebsd_triage 2021-01-06 15:47:01 UTC 
(In reply to Raphael Kubo da Costa from comment #1)
Ok, will keep it lowercase as u wish. :)

My local partial tree run (most of kde/gnome/xfce/lxde stuff) looks fine with this update. Most changes are bugfixes with no api rewrite, so it should be fine everywhere
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-01-06 16:10:13 UTC 
A commit references this bug:

Author: fluffy
Date: Wed Jan  6 16:09:15 UTC 2021
New revision: 560536
URL: https://svnweb.freebsd.org/changeset/ports/560536

Log:
  archivers/libzip: update to 1.7.3

  PR:		252456
  Submitted by:	fluffy
  Reported by:	Repology
  Approved by:	rakuco

Changes:
  head/archivers/libzip/Makefile
  head/archivers/libzip/distinfo
  head/archivers/libzip/files/patch-CMakeLists.txt
  head/archivers/libzip/pkg-plist
Comment 4 Dima Panov freebsd_committer freebsd_triage 2021-01-06 16:12:11 UTC 
Committed!
Comment 5 Raphael Kubo da Costa freebsd_committer freebsd_triage 2021-01-07 10:16:44 UTC 
In the end it wasn't the build system changes, but as 252483 shows an exp-run would have been useful...