Bug 252907 - [patch] misc/dahdi-kmod and misc/dahdi-kmod26 need -Wmisleading-indentation removed.
Summary: [patch] misc/dahdi-kmod and misc/dahdi-kmod26 need -Wmisleading-indentation r...
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Max Khon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-22 05:09 UTC by dgilbert
Modified: 2021-01-25 14:53 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (fjoe)


Attachments
poudriere build log for dahdi-kmod26 on 12.2 (33.27 KB, text/plain)
2021-01-22 05:09 UTC, dgilbert
no flags Details
patch for misc/dahdi-kmod (419 bytes, patch)
2021-01-25 14:48 UTC, dgilbert
no flags Details | Diff
patch for misc/dahdi-kmod26 (440 bytes, patch)
2021-01-25 14:49 UTC, dgilbert
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dgilbert 2021-01-22 05:09:22 UTC
Created attachment 221805 [details]
poudriere build log for dahdi-kmod26 on 12.2

So... neither of these two ports compile.  I've attached the poudriere build log to this ticket.

If you examine the file GpakApi.c with an editor that treats a TAB as 8 spaces, you'll see quite a bit of indention madness.  If you squint, however, it all makes sense at TAB as 4 spaces.

The simplest fix for this port is to remove the -Wmisleading-indentation from the compile.

How is that done?
Comment 1 dgilbert 2021-01-23 15:35:34 UTC
Adding some detail:

This compiles on 12.1 (and fails on 12.2).  I'm not yet sure if -Wmisleading-indentation was inserted in between (in, say, ports.mk or somesuch).
Comment 2 dgilbert 2021-01-25 14:48:40 UTC
Created attachment 221906 [details]
patch for misc/dahdi-kmod
Comment 3 dgilbert 2021-01-25 14:49:33 UTC
Created attachment 221907 [details]
patch for misc/dahdi-kmod26
Comment 4 dgilbert 2021-01-25 14:52:46 UTC
Patches fix things, checked on 12.1 and 12.2

In Short, turn off -Werror.
Comment 5 dgilbert 2021-01-25 14:53:51 UTC
And if the maintainer wants out, I have an interest in maintaining this port as I'm using it.