Bug 252964 - databases/tcl-sqlite3: Update to 3.34.1
Summary: databases/tcl-sqlite3: Update to 3.34.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Lewis Cook
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2021-01-24 07:03 UTC by Pavel Volkov
Modified: 2021-01-30 16:34 UTC (History)
2 users (show)

See Also:

Attachments
patch (1.30 KB, patch)
2021-01-24 07:03 UTC, Pavel Volkov 		pavelivolkov: maintainer-approval+
Details | Diff
poudriere log (20.80 KB, text/plain)
2021-01-24 07:05 UTC, Pavel Volkov 		no flags Details
patch (2.32 KB, patch)
2021-01-30 05:56 UTC, Pavel Volkov 		pavelivolkov: maintainer-approval+
Details | Diff
poudriere log (20.79 KB, text/plain)
2021-01-30 05:56 UTC, Pavel Volkov 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Volkov 2021-01-24 07:03:59 UTC 
Created attachment 221867 [details]
patch

[Update to 3.34.1](https://www.sqlite.org/releaselog/3_34_1.html)
Comment 1 Pavel Volkov 2021-01-24 07:05:25 UTC 
Created attachment 221868 [details]
poudriere log
Comment 2 Automation User 2021-01-24 07:36:25 UTC 
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/246009560
Comment 3 Lewis Cook freebsd_committer freebsd_triage 2021-01-24 13:28:48 UTC 
Moin moin, thank you for the submission. Just one minor nit:

$ portclippy Makefile

PORTNAME
PORTVERSION
CATEGORIES
MASTER_SITES
PKGNAMEPREFIX
DISTNAME

# Maintainer block
MAINTAINER
COMMENT

# License block
LICENSE

# Dependencies
LIB_DEPENDS

# USES block
USES
USE_LDCONFIG

# Configure block
+CONFIGURE_ARGS
-OPTIONS_DEFINE
-OPTIONS_DEFAULT

-WRKSRC

# CFLAGS/CXXFLAGS/LDFLAGS block
CFLAGS
LDFLAGS

# Standard bsd.port.mk variables
+SUB_FILES
+SUB_LIST
-CONFIGURE_ARGS

# WRKSRC block
+WRKSRC
-THREADS_CONFIGURE_ENABLE

# Packaging list block
PLIST_FILES
PORTEXAMPLES

# Options definitions
+OPTIONS_DEFINE
+OPTIONS_DEFAULT

# Options helpers
+THREADS_CONFIGURE_ENABLE
-SUB_FILES
-SUB_LIST

Would you mind re-ordering the variables as suggested by portclippy[1]? otherwise everything else looks fine. Thanks!

[1] https://www.freshports.org/ports-mgmt/portfmt - portclippy is part of the portfmt test-suite
Comment 4 Pavel Volkov 2021-01-30 05:56:05 UTC 
Created attachment 222018 [details]
patch

Path with ordered variables.
Comment 5 Pavel Volkov 2021-01-30 05:56:29 UTC 
Created attachment 222019 [details]
poudriere log
Comment 6 commit-hook freebsd_committer freebsd_triage 2021-01-30 16:33:31 UTC 
A commit references this bug:

Author: lcook
Date: Sat Jan 30 16:32:58 UTC 2021
New revision: 563421
URL: https://svnweb.freebsd.org/changeset/ports/563421

Log:
  databases/tcl-sqlite3: Update to 3.34.1

  While here, pet portclippy.

  Changes:		https://www.sqlite.org/releaselog/3_34_1.html
  PR:			252964
  Submitted by: 		Pavel Volkov <pavelivolkov@gmail.com> (maintainer)
  Approved by:		tcberner (mentor)
  Differential Revision:	https://reviews.freebsd.org/D28426

Changes:
  head/databases/tcl-sqlite3/Makefile
  head/databases/tcl-sqlite3/distinfo
Comment 7 Lewis Cook freebsd_committer freebsd_triage 2021-01-30 16:34:52 UTC 
Committed with minor changes, thanks!