Bug 253071 - www/chromium: chromium-88.0.4324.96 requires multimedia/libva to build
Summary: www/chromium: chromium-88.0.4324.96 requires multimedia/libva to build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rene Ladan
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2021-01-29 02:26 UTC by George Mitchell
Modified: 2021-02-01 19:51 UTC (History)
5 users (show)

See Also:

Attachments
patch for chromium Makefile (610 bytes, patch)
2021-01-29 02:26 UTC, George Mitchell 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description George Mitchell 2021-01-29 02:26:51 UTC 
Created attachment 222000 [details]
patch for chromium Makefile

Chrome will not build without libva installed.  I'm not sure whether it's required for chrome to run; it seems to run fine without it.  I have attached a patch that allows it to build.
Comment 1 Thomas Zander freebsd_committer freebsd_triage 2021-01-30 19:40:17 UTC 
Confirmed.
Comment 2 Rene Ladan freebsd_committer freebsd_triage 2021-01-30 20:28:31 UTC 
It builds fine on 11.4-i386, 12.2-amd64 in poudriere without libva when I tested it last week.
Comment 3 Rene Ladan freebsd_committer freebsd_triage 2021-01-30 20:30:30 UTC 
I'll start a build on head-amd64 (1400000) against r563435 just to be sure.
Comment 4 Christoph Moench-Tegeder freebsd_committer freebsd_triage 2021-01-30 21:19:17 UTC 
(In reply to Rene Ladan from comment #2)
By default libva gets pulled in via ffmpeg, where it's a default OPTION (VAAPI)
Comment 5 George Mitchell 2021-01-30 22:19:02 UTC 
Hmm, does that mean this is really a bug in ffmpeg's Makefile?
Comment 6 Craig Leres freebsd_committer freebsd_triage 2021-01-30 22:57:31 UTC 
(In reply to Christoph Moench-Tegeder from comment #4)
I have a explicit options for multimedia/ffmpeg that don't include VAAPI but still cannot configure/build; I think the problem is that the new version of chromium has a new direct dependency on libva.
Comment 7 Thomas Zander freebsd_committer freebsd_triage 2021-01-31 06:30:37 UTC 
(In reply to Craig Leres from comment #6)

This is also the reason why it does not build for me. I also build ffmpeg without libva, and chromium now depends on libva directly:

Current dir: /wrkdirs/usr/ports/www/chromium/work/chromium-88.0.4324.96/out/Release/
Command: python /wrkdirs/usr/ports/www/chromium/work/chromium-88.0.4324.96/build/config/linux/pkg-config.py libva
Returned 1.
stderr:

Package libva was not found in the pkg-config search path.
Perhaps you should add the directory containing `libva.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libva', required by 'virtual:world', not found
Could not run pkg-config.

See //build/config/linux/libva/BUILD.gn:9:1: whence it was called.
pkg_config("libva") {
^--------------------
See //media/gpu/BUILD.gn:473:26: which caused the file to be included.
      public_configs = [ "//build/config/linux/libva" ]
                         ^---------------------------
*** Error code 1

Stop.
make: stopped in /usr/ports/www/chromium
Comment 8 commit-hook freebsd_committer freebsd_triage 2021-02-01 19:50:53 UTC 
A commit references this bug:

Author: rene
Date: Mon Feb  1 19:50:12 UTC 2021
New revision: 563752
URL: https://svnweb.freebsd.org/changeset/ports/563752

Log:
  www/chromium: fix build when the VAAPI in multimedia/ffmpeg is switched off

  PR:		253071
  Submitted by:	george@m5p.com
  MFH:		2021Q1

Changes:
  head/www/chromium/Makefile
Comment 9 Rene Ladan freebsd_committer freebsd_triage 2021-02-01 19:51:45 UTC 
Patch committed, thanks!
Comment 10 commit-hook freebsd_committer freebsd_triage 2021-02-01 19:51:54 UTC 
A commit references this bug:

Author: rene
Date: Mon Feb  1 19:50:54 UTC 2021
New revision: 563753
URL: https://svnweb.freebsd.org/changeset/ports/563753

Log:
  MFH: r563752

  www/chromium: fix build when the VAAPI in multimedia/ffmpeg is switched off

  PR:		253071
  Submitted by:	george@m5p.com

Changes:
_U  branches/2021Q1/
  branches/2021Q1/www/chromium/Makefile