Bug 253531 - devel/libcrossguid: Update to latest commit and switch to CMake
Summary: devel/libcrossguid: Update to latest commit and switch to CMake
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias C. Berner
URL: https://github.com/graeme-hill/crossg...
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2021-02-15 10:28 UTC by daniel.engberg.lists
Modified: 2021-03-04 12:38 UTC (History)
2 users (show)

See Also:
mickael.maillot: maintainer-feedback+

Attachments
Patch for libcrossguid (4.51 KB, patch)
2021-02-15 10:28 UTC, daniel.engberg.lists 		no flags Details | Diff
Patch for libcrossguid v2 (4.51 KB, patch)
2021-02-15 10:31 UTC, daniel.engberg.lists 		no flags Details | Diff
Patch for libcrossguid v3 (4.57 KB, patch)
2021-02-15 10:34 UTC, daniel.engberg.lists 		no flags Details | Diff
Patch for libcrossguid v4 (5.00 KB, patch)
2021-02-24 14:32 UTC, daniel.engberg.lists 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description daniel.engberg.lists 2021-02-15 10:28:33 UTC 
Created attachment 222457 [details]
Patch for libcrossguid

The current version is very old and requires a lot of hacking, update to latest commit as the latest release was back in 2017 and switch to CMake.

Compile tested on FreeBSD 13.0-BETA2 (amd64) (make, make check-plist)
Poudriere testport OK 12.2-RELEASE (amd64)
Poudriere testport OK 11.4-RELEASE (amd64)
Comment 1 daniel.engberg.lists 2021-02-15 10:31:40 UTC 
Created attachment 222458 [details]
Patch for libcrossguid v2

Attached wrong patch, this one also pets portlint
Comment 2 daniel.engberg.lists 2021-02-15 10:34:58 UTC 
Created attachment 222459 [details]
Patch for libcrossguid v3

Take #3 , sorry :/
Comment 3 Automation User 2021-02-15 10:39:58 UTC 
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/256312045
Comment 4 daniel.engberg.lists 2021-02-24 14:32:59 UTC 
Created attachment 222790 [details]
Patch for libcrossguid v4

Move *.cmake files to a more common location
Comment 5 Tobias C. Berner freebsd_committer 2021-02-24 16:06:35 UTC 
@mickael.maillot@gmail.com could you quickly confirm, that you approve v4?

Ideally, you set the "maintainer-approval" flag on the patch for that.


mfg Tobias
Comment 6 daniel.engberg.lists 2021-03-03 21:19:00 UTC 
Hi Mickael,

Does this patch look good to you?

Regards,
Daniel
Comment 7 mickael.maillot 2021-03-04 12:38:46 UTC 
i'm sorry i don't have the time to test it on i386 and against dependencies