Bug 253531 - devel/libcrossguid: Update to latest commit and switch to CMake
Summary: devel/libcrossguid: Update to latest commit and switch to CMake
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias C. Berner
URL: https://github.com/graeme-hill/crossg...
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2021-02-15 10:28 UTC by Daniel Engberg
Modified: 2022-01-01 19:26 UTC (History)
3 users (show)

See Also:
mickael.maillot: maintainer-feedback+


Attachments
Patch for libcrossguid (4.51 KB, patch)
2021-02-15 10:28 UTC, Daniel Engberg
no flags Details | Diff
Patch for libcrossguid v2 (4.51 KB, patch)
2021-02-15 10:31 UTC, Daniel Engberg
no flags Details | Diff
Patch for libcrossguid v3 (4.57 KB, patch)
2021-02-15 10:34 UTC, Daniel Engberg
no flags Details | Diff
Patch for libcrossguid v4 (5.00 KB, patch)
2021-02-24 14:32 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2021-02-15 10:28:33 UTC
Created attachment 222457 [details]
Patch for libcrossguid

The current version is very old and requires a lot of hacking, update to latest commit as the latest release was back in 2017 and switch to CMake.

Compile tested on FreeBSD 13.0-BETA2 (amd64) (make, make check-plist)
Poudriere testport OK 12.2-RELEASE (amd64)
Poudriere testport OK 11.4-RELEASE (amd64)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2021-02-15 10:31:40 UTC
Created attachment 222458 [details]
Patch for libcrossguid v2

Attached wrong patch, this one also pets portlint
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2021-02-15 10:34:58 UTC
Created attachment 222459 [details]
Patch for libcrossguid v3

Take #3 , sorry :/
Comment 3 Automation User 2021-02-15 10:39:58 UTC
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/256312045
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2021-02-24 14:32:59 UTC
Created attachment 222790 [details]
Patch for libcrossguid v4

Move *.cmake files to a more common location
Comment 5 Tobias C. Berner freebsd_committer freebsd_triage 2021-02-24 16:06:35 UTC
@mickael.maillot@gmail.com could you quickly confirm, that you approve v4?

Ideally, you set the "maintainer-approval" flag on the patch for that.


mfg Tobias
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2021-03-03 21:19:00 UTC
Hi Mickael,

Does this patch look good to you?

Regards,
Daniel
Comment 7 mickael.maillot 2021-03-04 12:38:46 UTC
i'm sorry i don't have the time to test it on i386 and against dependencies
Comment 8 commit-hook freebsd_committer freebsd_triage 2021-12-23 21:21:32 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ddc0332a1c48da23f4d4bc5f71e68ad7aa513dfb

commit ddc0332a1c48da23f4d4bc5f71e68ad7aa513dfb
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2021-12-23 21:08:42 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2021-12-23 21:21:00 +0000

    devel/libcrossguid: Update to latest commit and switch to CMake

    The current version is very old and requires a lot of hacking, update
    to latest commit as the latest release was back in 2017 and switch
    to CMake. This update also includes following commit from 3rd party
    repo for performance:
    https://github.com/jhaws1982/crossguid/commit/23a8c007a668413c2e8cbd00984d223ed5ecfe05

    PR:             253531
    Approved by:    mentors (implicit), Mickael Maillot (maintainer timeout, 9+ months)
    Differential Revision:  https://reviews.freebsd.org/D33415

 devel/libcrossguid/Makefile                        | 40 ++++++----------------
 devel/libcrossguid/distinfo                        |  7 ++--
 devel/libcrossguid/files/libcrossguid.pc.in (gone) |  9 -----
 .../libcrossguid/files/patch-CMakeLists.txt (new)  | 20 +++++++++++
 devel/libcrossguid/pkg-plist (new)                 |  9 +++++
 5 files changed, 45 insertions(+), 40 deletions(-)
Comment 9 Jose Alonso Cardenas Marquez freebsd_committer freebsd_triage 2021-12-31 17:36:05 UTC
Hi, don't forget bump PORTREVISION of multimedia/kodi, It depends of libcrossguid. Keep in mind when a library is updated, you must bump PORTREVISION to each ports depends of it
Comment 10 Daniel Engberg freebsd_committer freebsd_triage 2022-01-01 19:26:32 UTC
Sorry about that, kodi got bumped for another lib here https://cgit.freebsd.org/ports/commit/?id=b55bac28814d0008a021aa08922a28e2c0ba9d7b so it should be fine now.