Bug 253696 - sysutils/node_exporter: add SMART support
Summary: sysutils/node_exporter: add SMART support
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mateusz Piotrowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-19 16:29 UTC by Lapo Luchini
Modified: 2022-03-10 08:58 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (dor.bsd)

Attachments
/usr/local/sbin/smartmon_exporter (7.13 KB, patch)
2021-02-19 16:29 UTC, Lapo Luchini 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lapo Luchini 2021-02-19 16:29:41 UTC 
Created attachment 222642 [details]
/usr/local/sbin/smartmon_exporter

I suggest installing this script as part of the standard port, so that if the user wants to have smartd reports inside the normal node_exporter output, it just needs to do something like this:

printf "*/1\t*\t*\t*\t*\troot\t/usr/local/sbin/smartmon_exporter\n" >> /etc/crontab
Comment 1 Lapo Luchini 2021-03-09 18:41:24 UTC 
PS: I'm using it with success with this Grafana dashboard:
https://grafana.com/grafana/dashboards/10530
Comment 2 Mateusz Piotrowski freebsd_committer freebsd_triage 2021-12-07 10:51:17 UTC 
The script itself could indeed be useful in some cases to. However, it seems like it would be much better to just have it in the ports collection as a separate port. There is no good reason to install it as a part of node_exporter.

Please create a new port if you'd like to have this script in the ports collection.

Cheers!
Comment 3 Mateusz Piotrowski freebsd_committer freebsd_triage 2021-12-07 10:56:20 UTC 
BTW, this exporter is a part of this repo: https://github.com/prometheus-community/node-exporter-textfile-collector-scripts