Bug 253743 - graphics/zbar: update to 0.23.90
Summary: graphics/zbar: update to 0.23.90
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL: https://github.com/mchehab/zbar/relea...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-21 13:58 UTC by VVD
Modified: 2021-02-24 12:43 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (dev2)


Attachments
update to 0.23.90 (10.80 KB, patch)
2021-02-21 13:58 UTC, VVD
no flags Details | Diff
update to 0.23.90 (10.87 KB, patch)
2021-02-21 21:34 UTC, VVD
no flags Details | Diff
update to 0.23.90 v3 (10.94 KB, patch)
2021-02-23 09:47 UTC, VVD
no flags Details | Diff
poudriere build log (120.61 KB, text/plain)
2021-02-23 21:42 UTC, Fernando Apesteguía
no flags Details
update to 0.23.90 v4 (10.98 KB, patch)
2021-02-24 11:40 UTC, VVD
vvd: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description VVD 2021-02-21 13:58:59 UTC
Created attachment 222700 [details]
update to 0.23.90

Changed upstream hosting, added build options: DBUS GIR JPEG NLS QT5 GRAPHICSMAGICK GTK2 GTK3 (not added JAVA and PYTHON - patches are welcome).
A lot of changes from 0.10: https://github.com/mchehab/zbar/blob/master/ChangeLog

Tested on 12.2 amd64: build, install, check-plist, build dependent from zbar graphics/gstreamer1-plugins-zbar with different combinations of the options.
Comment 1 VVD 2021-02-21 21:34:56 UTC
Created attachment 222708 [details]
update to 0.23.90

Added fix from upstream for configure script + updates after make stage-qa.
Comment 2 VVD 2021-02-21 22:07:53 UTC
All dependent ports should be recompiled.
Comment 3 VVD 2021-02-21 22:27:14 UTC
Dependent ports:

1. graphics/gstreamer1-plugins-zbar - build without errors.

2. graphics/py-zbar-py - build without errors.

3. graphics/qtqr - build without errors and work fine.

4. graphics/p5-Barcode-ZBar - build error with new version of the zbar:
ZBar.xs:202:36: error: too few arguments to function call, expected 3, have 2
        zbar_version(&major, &minor);
        ~~~~~~~~~~~~               ^
/usr/local/include/zbar.h:270:1: note: 'zbar_version' declared here
extern int zbar_version(unsigned *major,
^
1 error generated.
*** [ZBar.o] Error code 1

Build fine with this patch (graphics/p5-Barcode-ZBar/files/patch-ZBar.xs): 
--- ZBar.xs.orig
+++ ZBar.xs
@@ -198,9 +198,10 @@
     PREINIT:
        unsigned major;
         unsigned minor;
+        unsigned patch;
     CODE:
-        zbar_version(&major, &minor);
-        RETVAL = newSVpvf("%u.%u", major, minor);
+        zbar_version(&major, &minor, &patch);
+        RETVAL = newSVpvf("%u.%u.%u", major, minor, patch);
     OUTPUT:
         RETVAL
Comment 4 Fernando Apesteguía freebsd_committer 2021-02-22 12:52:37 UTC
Q/A:  /tmp/253743/graphics/zbar/files/patch-configure.ac: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
 /tmp/253743/graphics/zbar/files/patch-zbarcam_scan__video.c: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.

^Triage: Please confirm this change passes QA (portlint, poudriere at least).
--
https://www.freebsd.org/doc/en/books/porters-handbook/testing.html

Q/A: CONFIGURE_ARGS is out of place
# Configure block                                
GNU_CONFIGURE                         
+CONFIGURE_ARGS                      
                                                                                                            
# Make block                                                                                                
INSTALL_TARGET                                                                                              
                                                      
-CONFIGURE_ARGS                 

Thanks!
Comment 5 VVD 2021-02-23 09:47:54 UTC
Created attachment 222750 [details]
update to 0.23.90 v3

(In reply to Fernando Apesteguía from comment #4)
Done.
Check, plz, are all correct?
Comment 6 Fernando Apesteguía freebsd_committer 2021-02-23 17:02:21 UTC
(In reply to VVD from comment #5)
===========================================================================
====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: man/man1/zbarimg.1.gz
===> Error: Plist issues found.
*** Error code 1

Please, test the patches before submitting :-)
Comment 7 VVD 2021-02-23 20:14:48 UTC
(In reply to Fernando Apesteguía from comment #6)
check-plist work fine for me with default options (and all other combinations I tested - 10+ different).
What options do you use?
Show full build log.
Comment 8 Fernando Apesteguía freebsd_committer 2021-02-23 21:42:12 UTC
Created attachment 222768 [details]
poudriere build log

Poudriere log for 12.2amd64

Tested in {11,412.2}{amd64,i386}
Comment 9 VVD 2021-02-24 11:40:11 UTC
Created attachment 222787 [details]
update to 0.23.90 v4

It check for xmlto and silent turn off copy of man files if not find even with configure option --enable-doc…
Comment 10 Fernando Apesteguía freebsd_committer 2021-02-24 12:43:07 UTC
LGTM.

I'll wait a bit more to give maintainer a chance to chime in.