Bug 253776 - [PATCH] multimedia/rtmpdump: fix build without optimizations
Summary: [PATCH] multimedia/rtmpdump: fix build without optimizations
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Hiroki Sato
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2021-02-22 23:36 UTC by Michael Zhilin
Modified: 2021-03-09 00:12 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (hrs)

Attachments
SVN diff (725 bytes, patch)
2021-02-22 23:36 UTC, Michael Zhilin 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Zhilin freebsd_committer 2021-02-22 23:36:39 UTC 
Created attachment 222733 [details]
SVN diff

Hi,

Build of multimedia/rtmpdump may fail in case of no optimization. For instance, if make.conf contains "WITH_DEBUG=yes" and "DEBUG_FLAGS=-g". 
The error message is following:

--- rtmpdump ---
ld: error: undefined symbol: CleanupSockets
>>> referenced by rtmpdump.c:1410
>>>               rtmpdump.o:(main)
cc: error: linker command failed with exit code 1 (use -v to see invocation)
*** [rtmpdump] Error code 1

The reason is incorrect definition of inline function CleanupSockets. The suggested patch adds "static" in definition of function and fixes problem. 

Testport is done on default and "debug" environment, on 12.2 and 13.0-BETA1.

Thanks!
Comment 1 Automation User 2021-03-09 00:12:26 UTC 
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/267328462