Bug 253868 - Various periodic(8) fixes
Summary: Various periodic(8) fixes
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Ceri Davies
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-26 10:28 UTC by Ceri Davies
Modified: 2021-06-02 16:36 UTC (History)
2 users (show)

See Also:

Attachments
Patch to address issues described. (4.78 KB, patch)
2021-02-26 10:28 UTC, Ceri Davies 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ceri Davies 2021-02-26 10:28:12 UTC 
Created attachment 222842 [details]
Patch to address issues described.

1) /etc/periodic has special cases for zcat and bzcat,
 but not for zstd and xz which newsyslog also supports.

2) newsyslog.conf manpage does not have a xref for zstd(1).

3) usr.sbin/periodic/etc/monthly/200.accounting does not use temporary
    files appropriately.

4) periodic.conf(5) refers to "daily accounting" and
    "monthly accounting" withouth being clear that "daily"
    means process accounting and "monthly" is login accounting.
Comment 1 Ceri Davies 2021-03-15 09:49:11 UTC 
https://reviews.freebsd.org/D29267
Comment 2 Ceri Davies freebsd_committer freebsd_triage 2021-05-11 15:23:48 UTC 
I'll have this back
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-06-02 16:35:23 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=774bb1c256fbc58a7e8d0d1f7d6427007105b334

commit 774bb1c256fbc58a7e8d0d1f7d6427007105b334
Author:     Ceri Davies <ceri@FreeBSD.org>
AuthorDate: 2021-06-02 16:28:28 +0000
Commit:     Ceri Davies <ceri@FreeBSD.org>
CommitDate: 2021-06-02 16:28:28 +0000

    periodic: add support for .xz and .zcat compressed logs

    Also improve temporary file usage in 200.accounting, add an xref to
    zstd(1) to newsyslog.conf.5, and clarify in periodic.conf that
    "daily accounting" means process accounting and "monthly accounting"
    is login accounting.

    PR:             253868
    Reviewed by:    allanjude
    Approved by:    blackend (mentor)
    Differential Revision:  https://reviews.freebsd.org/D29267

 share/man/man5/periodic.conf.5                     |  2 +-
 usr.sbin/newsyslog/newsyslog.conf.5                |  1 +
 .../periodic/etc/daily/460.status-mail-rejects     |  6 +++++
 usr.sbin/periodic/etc/monthly/200.accounting       | 30 ++++++++++++++++------
 usr.sbin/periodic/etc/security/800.loginfail       |  2 ++
 usr.sbin/periodic/etc/security/900.tcpwrap         |  2 ++
 6 files changed, 34 insertions(+), 9 deletions(-)