Created attachment 222946 [details] SVN patch from ports root Hi, This is a port of Sylvester the Cat's Common Lisp IDE for Emacs, an interesting fork of SLIME. SVN patch attached. Regards.
There seems to have some missing dependencies: https://gist.github.com/lwhsu/be7eb890e005013d5d8f6aceab0d0ee1
Seems so indeed... `git` is apparently used in some Makefile's recipe used to produce the doc. It can probably be short-circuited. I'll post an update soon. Thanks.
Created attachment 223124 [details] SVN patch from ports root v2 v1 with doc's build's implicit dependency on 'git' removed.
Could you test again, please?
It looks still some dependencies (tex?) missing https://gist.github.com/fca7d1e3a4464c6016be8c37e61fcaeb
Created attachment 223167 [details] SVN patch from ports root v3 Sorry for this. Patch updated. Added a new option DOCS_PDF that depends on DOCS and triggers building of PDF files. In this case, a dependency on pdftex at build is registered. Could you try again?
Still doesn't build: https://gist.github.com/91b613007dbab2f044d1f4438c02e396 If this is not critical, maybe you can disable doc build first, although it's not very recommended. Also, it's unfortunately that we don't have our public port testing infra revived yet. Do you think you can setup a poudriere locally to test it? I'm happy to help you to test, but it might be easier for you to get the quick response.
No problem for me, but indeed I didn't expect to have to bother you so much. Before the last patch I posted, I had set up a new jail with just the minimum packages, that's how I saw what to add. And I didn't have the failure you're reporting in the end, so there is something strange. Going to look into it, and I'll post when I have something new. I've not setup poudriere for years, but maybe it's time to do so again (but my time is quite limited).
Created attachment 223174 [details] SVN patch from ports root v4 Think I got it. The missing file in the error log belongs to package tex-dvipsk. In fact, I had tested adding USE_TEX=dvipsk, leading to installation of the corresponding package, but then I removed it, leaving the package installed in the jail. That's why I was not seeing this error. If I remove the package, I indeed see it. So we should be good now... Thanks for your patience.
(In reply to Olivier Certner from comment #9) Sorry for the delay and it test good to me. Just one minor nitpick: what do you think if we rename THIS_LISPDIR to SLY_LISPDIR for a more specified variable name? Also I think for pkg-plist we can just use %%EMACS_VERSION_SITE_LISPDIR%%/sly (${PREFIX} included}.
(In reply to Li-Wen Hsu from comment #10) I can handle these changes if you agree, no need to provide a new patch (but it's welcomed, of course.)
(In reply to Li-Wen Hsu from comment #10) I would prefer not and keep THIS_LISPDIR. Of course it could be renamed to SLY_LISPDIR, as SLIME does, but I used the same variable in other new ports of external contribs, meaning less changes and mental burden, since it is handled the same way everywhere, and its name would be quite long in the contribs. THIS_LISPDIR is supposed to be the lisp directory for the current port, don't you find that clearer (or, at least, as clear)? For pkg-plist, it's a bit the same, %%EMACS_VERSION_SITE_LISPDIR%%/sly is longer, and giving details ('sly' inside the Emacs directory) which must be kept in sync with where the Makefile installs the files anyway. So here again I would prefer to keep things like that. Apparently, pkg-plist must list paths without PREFIX, so a change is in order because the THIS_LISPDIR passed through PLIST_SUB starts with PREFIX, and it should not. Going to make patches for that (here and in the external contrib ports). Would leaving THIS_LISPDIR as is (name + use in pkg-plist) and patching so PREFIX doesn't get into pkg-plist's paths OK for you?
(In reply to Olivier Certner from comment #12) > Would leaving THIS_LISPDIR as is (name + use in pkg-plist) and patching so PREFIX doesn't get into pkg-plist's paths OK for you? Sure, I was just asking your opinion. BTW in comment #10 I mean "${PREFIX} excluded".
> BTW in comment #10 I mean "${PREFIX} excluded". Yes, I figured that out, because this prompted me to check what 'pkg-plist' was supposed to contain path-wise in the porters handbook. ;-) I'll patch all ports (this one + external contribs), later tonight or tomorrow. Thanks for the review.
Created attachment 223269 [details] SVN patch from ports root v5 Changes over previous patch: 1. THIS_LISPDIR set to the value without prefix for use in pkg-plist.
Done. I've updated the PRs for the external contribs also. Thanks.
A commit references this bug: Author: lwhsu Date: Tue Mar 16 10:35:11 UTC 2021 New revision: 568549 URL: https://svnweb.freebsd.org/changeset/ports/568549 Log: Add editors/sly, Common Lisp IDE for Emacs PR: 253991 Submitted by: Olivier Certner <olivier.freebsd@free.fr> Changes: head/editors/Makefile head/editors/sly/ head/editors/sly/Makefile head/editors/sly/distinfo head/editors/sly/files/ head/editors/sly/files/patch-doc_Makefile head/editors/sly/files/patch-doc_sly.texi head/editors/sly/files/patch-sly.el head/editors/sly/pkg-descr head/editors/sly/pkg-message head/editors/sly/pkg-plist
Thanks Li-Wen!