Bug 254274 - lang/duktape-lib: add pkgconf file
Summary: lang/duktape-lib: add pkgconf file
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Charlie Li
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-14 11:47 UTC by Piotr Pawel Stefaniak
Modified: 2022-02-07 22:01 UTC (History)
7 users (show)

See Also:
asiciliano: maintainer-feedback+


Attachments
patch duktape-lib to install a pkgconf file (2.01 KB, patch)
2021-03-14 11:47 UTC, Piotr Pawel Stefaniak
no flags Details | Diff
v2 (2.31 KB, patch)
2022-02-06 20:40 UTC, Charlie Li
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Pawel Stefaniak freebsd_committer freebsd_triage 2021-03-14 11:47:51 UTC
Created attachment 223256 [details]
patch duktape-lib to install a pkgconf file

This will allow configure scripts to pick it up, specifically the one in a feature branch of polkit that supports using duktape in place of spidermonkey.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2021-03-15 10:57:45 UTC
^Triage: Reporter is committer, assign accordingly.

^Triage: [tags] in issue Titles are deprecated.

^Triage: Simplifying title


Thanks!
Comment 2 Piotr Pawel Stefaniak freebsd_committer freebsd_triage 2021-03-15 12:39:52 UTC
I'm not a ports committer.
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2021-03-15 12:42:56 UTC
(In reply to Piotr Pawel Stefaniak from comment #2)

Any committer may commit to any repository with an accepted review from any committer with existing access to that repository.

Committers may obtain review via a Differential in Phabricator, adding the "Contributor Reviewers ($Repository)" group as a Reviewer, reaching out to other committers; directly or via mailing lists, or setting the attachment flag to: maintainer-approval ? <person-youd-like-to-review>
Comment 4 Charlie Li freebsd_committer freebsd_triage 2022-02-06 19:51:22 UTC
Reopening, this is needed for sysutils/polkit's new duktape support.
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2022-02-06 20:07:39 UTC
USES= pkgconfig isn't needed, SUB_LIST+= should use \ instead of defining it for each line, PORTREVISION needs to be bumped
Comment 6 Charlie Li freebsd_committer freebsd_triage 2022-02-06 20:40:58 UTC
Created attachment 231584 [details]
v2

Update/rebase; currently dogfooding
Comment 7 Dima Panov freebsd_committer freebsd_triage 2022-02-06 21:11:36 UTC
(In reply to Charlie Li from comment #6)
Go ahead, Charlie!
Comment 8 Daniel Engberg freebsd_committer freebsd_triage 2022-02-06 21:48:01 UTC
Upstream fix submitted, https://gitlab.freedesktop.org/polkit/polkit/-/merge_requests/108
Comment 9 commit-hook freebsd_committer freebsd_triage 2022-02-07 21:59:41 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=dd1d30077348a5ffdad451e3477aab6a5bd15e9d

commit dd1d30077348a5ffdad451e3477aab6a5bd15e9d
Author:     Piotr Pawel Stefaniak <pstef@freebsd.org>
AuthorDate: 2022-02-06 20:34:59 +0000
Commit:     Charlie Li <vishwin@FreeBSD.org>
CommitDate: 2022-02-07 21:58:00 +0000

    lang/duktape-lib: add pkgconf file

    This is needed for sysutils/polkit's duktape support, but also makes
    it easier for other consumers to use the library.

    While here, cosmetic cleanups.

    PR:             254274
    Reviewed by:    diizzy
    Tested by:      vishwin
    Approved by:    Alfonso S. Siciliano <alfix86[at]gmail[dot]com> (maintainer),
                    fluffy (mentor)

 lang/duktape-lib/Makefile                  | 10 +++++++++-
 lang/duktape-lib/files/duktape.pc.in (new) | 11 +++++++++++
 2 files changed, 20 insertions(+), 1 deletion(-)