Bug 254339 - net/cloud-init: fix modifying rc.conf in cc_salt_minion
Summary: net/cloud-init: fix modifying rc.conf in cc_salt_minion
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Brad Davis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-16 17:01 UTC by Brad Davis
Modified: 2021-03-18 19:21 UTC (History)
3 users (show)

See Also:
andrey: maintainer-feedback+


Attachments
patch (1.97 KB, patch)
2021-03-16 17:01 UTC, Brad Davis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brad Davis freebsd_committer 2021-03-16 17:01:57 UTC
Created attachment 223327 [details]
patch

The rhel update_sysconfig_file() isn't well suited for *BSD style rc.conf so use the set_rc_config_value() instead.

This fixes a bug that prevents the salt module from enabling the salt minion in rc.conf.

Mina: Please upstream if you want.
Comment 1 commit-hook freebsd_committer 2021-03-17 15:28:56 UTC
A commit references this bug:

Author: brd
Date: Wed Mar 17 15:28:54 UTC 2021
New revision: 568666
URL: https://svnweb.freebsd.org/changeset/ports/568666

Log:
  net/cloud-init: Fix modifying rc.conf in cc_salt_minion

  PR:		254339
  Approved by:	Andrey Fesenko (maintainer), swills

Changes:
  head/net/cloud-init/Makefile
  head/net/cloud-init/files/
  head/net/cloud-init/files/patch-cloudinit_config_cc__salt__minion.py
Comment 2 Li-Wen Hsu freebsd_committer 2021-03-18 13:28:49 UTC
Can this ticket be closed? Or it needs MFH?
Comment 3 Brad Davis freebsd_committer 2021-03-18 18:15:28 UTC
MFH is probably a good idea, but mostly I was hoping Mina would confirm upstreaming the fix.
Comment 4 Mina Galić 2021-03-18 19:21:47 UTC
Mina is currently very busy, but will bei happily upstream this