Bug 254426 - math/cadabra2: Fix packaging with Python 3.8 and onward
Summary: math/cadabra2: Fix packaging with Python 3.8 and onward
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kai Knoblich
URL:
Keywords:
Depends on:
Blocks: 253815
  Show dependency tree / graph
 
Reported: 2021-03-20 09:11 UTC by Kai Knoblich
Modified: 2021-03-21 18:22 UTC (History)
1 user (show)

See Also:
yuri: maintainer-feedback+

Attachments
cadabra2-fix-packaging-with-py38.patch (1.22 KB, patch)
2021-03-20 09:11 UTC, Kai Knoblich 		kai: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Knoblich freebsd_committer freebsd_triage 2021-03-20 09:11:18 UTC 
Created attachment 223444 [details]
cadabra2-fix-packaging-with-py38.patch

Hi Yuri,

if built with PYTHON3_DEFAULT=3.8 the math/cadabra2 port fails to package due a slightly different name of the .so file. Attached is a patch that remedies the problem.

QA:
~~~
- poudriere -> OK (12.2-RELEASE amd64 with PYTHON3_DEFAULT=3.7)
- poudriere -> OK (12.2-RELEASE amd64 with PYTHON3_DEFAULT=3.8)
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2021-03-20 09:42:25 UTC 
Approved, thank you!
Comment 2 Kai Knoblich freebsd_committer freebsd_triage 2021-03-21 08:33:10 UTC 
Comment on attachment 223444 [details]
cadabra2-fix-packaging-with-py38.patch

^ Triage: Set maintainer-approval flag to '+' as the approval was given in comment #1.
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-03-21 08:34:49 UTC 
A commit references this bug:

Author: kai
Date: Sun Mar 21 08:34:17 UTC 2021
New revision: 568906
URL: https://svnweb.freebsd.org/changeset/ports/568906

Log:
  math/cadabra2: Fix packaging with Python 3.8 and onward

  * Add a workaround to make the transition from Python 3.7 to Python 3.8
    possible because the name of the .so file is slightly different between
    the two releases.

  PR:		254426
  Approved by:	yuri (maintainer)

Changes:
  head/math/cadabra2/Makefile
  head/math/cadabra2/pkg-plist
Comment 4 Kai Knoblich freebsd_committer freebsd_triage 2021-03-21 08:36:22 UTC 
(In reply to Yuri Victorovich from comment #1)

Committed, thank you for the review and approval!
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2021-03-21 18:22:46 UTC 
(In reply to Kai Knoblich from comment #4)

Thank you for working on this!