Bug 254456 - lang/squeak: Fix build in 14.0-current
Summary: lang/squeak: Fix build in 14.0-current
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-21 10:24 UTC by takeshi.mutoh
Modified: 2021-03-26 19:41 UTC (History)
2 users (show)

See Also:


Attachments
Ignore two serial speeds B576000 and B1152000. (1.49 KB, patch)
2021-03-21 10:24 UTC, takeshi.mutoh
no flags Details | Diff
Ignore two serial speeds B576000 and B1152000 and update by make makepatch. (5.83 KB, patch)
2021-03-24 01:41 UTC, takeshi.mutoh
takeshi.mutoh: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description takeshi.mutoh 2021-03-21 10:24:56 UTC
Created attachment 223469 [details]
Ignore two serial speeds B576000 and B1152000.

At 14.0-Current, some serial speeds added at /usr/include/sys/_termios.h.
 https://cgit.freebsd.org/src/commit/sys/sys/_termios.h?id=0209400ceaed553a3f06a5f3759de992ddb58037

The lang/squeak ports assume B576000 and B1152000.
Lack of B576000 and B1152000 at /usr/include/sys/_termios.h, lang/squeak is broken at 14.0-Current.

I create a workaround patch.
Please commit it.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2021-03-23 13:29:27 UTC
^Triage: [tags] in issue Titles are deprecated.

^Triage: Simplifying title

^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.
--
Attachment -> Details -> maintainer-approval [+]

Q/A:
 /tmp/254456/lang/squeak/files/patch-unix_plugins_CameraPlugin_sqCamera-linux.c: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
 /tmp/254456/lang/squeak/files/patch-unix_plugins_ScratchPlugin_unixSeriaPort2Ops.c: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
 /tmp/254456/lang/squeak/files/patch-unix_plugins_UUIDPlugin_config.cmake: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
 /tmp/254456/lang/squeak/files/patch-unix_vm-sound-pulse_sqUnixSoundPulseAudio.c: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
 /tmp/254456/lang/squeak/files/patch-unix_vm_build.cmake: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
 /tmp/254456/lang/squeak/files/patch-unix_vm_sqUnixMain.c: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.

Thanks!
Comment 2 takeshi.mutoh 2021-03-24 01:41:35 UTC
Created attachment 223538 [details]
Ignore two serial speeds B576000 and B1152000 and update by make makepatch.

Update patch created by make makepatch.

Real change is Ignore two serial speeds B576000 and B1152000 only.
Comment 3 takeshi.mutoh 2021-03-24 01:43:01 UTC
Thank you for checking my patch.

I create updated patch.
This patch is recreated by make makepatch.
So some patch is update automatically without real change.

Please check again.
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2021-03-26 19:40:57 UTC
Committed with some changes.

Thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-03-26 19:41:16 UTC
A commit references this bug:

Author: fernape
Date: Fri Mar 26 19:40:38 UTC 2021
New revision: 569267
URL: https://svnweb.freebsd.org/changeset/ports/569267

Log:
  lang/squeak: Fix build in 14.0-current

  The lang/squeak ports assume B576000 and B1152000.
  Lack of B576000 and B1152000 at /usr/include/sys/_termios.h, lang/squeak is
  broken at 14.0-Current.

  While here, add missing USES, dependencies, reorder variables, etc.

  PR:	254456
  Submitted by:	takeshi.mutoh@gmail.com (maintainer)

Changes:
  head/lang/squeak/Makefile
  head/lang/squeak/files/patch-unix_plugins_CameraPlugin_sqCamera-linux.c
  head/lang/squeak/files/patch-unix_plugins_ScratchPlugin_unixSeriaPort2Ops.c
  head/lang/squeak/files/patch-unix_plugins_SerialPlugin_sqUnixSerial.c
  head/lang/squeak/files/patch-unix_plugins_UUIDPlugin_config.cmake
  head/lang/squeak/files/patch-unix_vm-sound-pulse_sqUnixSoundPulseAudio.c
  head/lang/squeak/files/patch-unix_vm_build.cmake
  head/lang/squeak/files/patch-unix_vm_sqUnixMain.c