Bug 254501 - devel/py-ice37: Fix build with Python 3.8
Summary: devel/py-ice37: Fix build with Python 3.8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kai Knoblich
URL: http://package22.nyi.freebsd.org/data...
Keywords:
Depends on:
Blocks: 253815
  Show dependency treegraph
 
Reported: 2021-03-23 12:55 UTC by Kai Knoblich
Modified: 2021-03-29 17:16 UTC (History)
1 user (show)

See Also:
grembo: maintainer-feedback+


Attachments
py-ice37-fix-build-with-py38.patch (2.10 KB, patch)
2021-03-23 12:55 UTC, Kai Knoblich
grembo: maintainer-approval+
grembo: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Knoblich freebsd_committer 2021-03-23 12:55:32 UTC
Created attachment 223521 [details]
py-ice37-fix-build-with-py38.patch

Hi Michael,

attached is a patch that fixes devel/py-ice37 if built with Python 3.8 by backporting the commit of issue #635. This should complete ports r559094 as well.

QA:
~~~

Build of devel/ice37, devel/php-ice37, devel/py-ice37:

- poudriere -> OK (12.2-RELEASE amd64, with PYTHON_DEFAULT=3.8)
- poudriere -> OK (11.4-, 12.2-RELEASE, 13.0-RC3, 14.0-CURRENT@a9f11355 amd64 i386, with PYTHON_DEFAULT=3.7)

Results of "make test" of devel/py-ice37 with TEST option set (12.2-RELEASE amd64 with PYTHON_DEFAULT set to 3.7 or 3.8):

> Ran 35 tests in NN.NN seconds
> 35 succeeded
Comment 1 Michael Gmelin freebsd_committer 2021-03-29 12:46:07 UTC
Looks good to me. Thanks!
Comment 2 Michael Gmelin freebsd_committer 2021-03-29 12:47:17 UTC
Can you commit or should it?
Comment 3 commit-hook freebsd_committer 2021-03-29 16:49:52 UTC
A commit references this bug:

Author: kai
Date: Mon Mar 29 16:49:30 UTC 2021
New revision: 569484
URL: https://svnweb.freebsd.org/changeset/ports/569484

Log:
  devel/py-ice37: Fix build with Python 3.8

  * Complete r559094 by backporting remaining bits from upstream repository
    and adding the usual fixes for the pkg-plist.

  PR:		254501
  Approved by:	grembo (maintainer)

Changes:
  head/devel/ice37/Makefile
  head/devel/ice37/distinfo
  head/devel/py-ice37/pkg-plist
Comment 4 Kai Knoblich freebsd_committer 2021-03-29 17:16:08 UTC
(In reply to Michael Gmelin from comment #2)

Many thanks for your review and approval! I committed the patch with a small change:

I used PATCH_SITES and PATCHFILES so you can simply remove those lines with the next update of devel/ice37 instead of reverting the fix in the ${WRKSRC}/python/config/Make.rules file.