Bug 254502 - net-mgmt/nagstamon: Fix build with Python 3.8 and onward
Summary: net-mgmt/nagstamon: Fix build with Python 3.8 and onward
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks: 253815
  Show dependency tree / graph
 
Reported: 2021-03-23 12:58 UTC by Kai Knoblich
Modified: 2021-03-23 16:59 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (ehaupt)

Attachments
nagstamon-fix-build-with-py38.patch (1.04 KB, patch)
2021-03-23 12:58 UTC, Kai Knoblich 		kai: maintainer-approval? (ehaupt)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Knoblich freebsd_committer freebsd_triage 2021-03-23 12:58:48 UTC 
Created attachment 223522 [details]
nagstamon-fix-build-with-py38.patch

Hi Emanuel,

attached is a patch that fixes net-mgmt/nagstamon if built with Python 3.8 and onward:

> ===>  Configuring for nagstamon-3.4.1_3
> Traceback (most recent call last):
>   File "<string>", line 1, in <module>
>   File "setup.py", line 40, in <module>
>     DIST, DIST_VERSION, DIST_NAME = platform.dist()
> AttributeError: module 'platform' has no attribute 'dist'
> *** Error code 1

QA:
~~~

- poudriere -> OK (12.2-RELEASE amd64, with PYTHON_DEFAULT=3.8)
- poudriere -> OK (12.2-RELEASE, 13.0-RC3, 14.0-CURRENT@a9f11355 amd64 i386, with PYTHON_DEFAULT=3.7)
Comment 1 commit-hook freebsd_committer freebsd_triage 2021-03-23 16:58:20 UTC 
A commit references this bug:

Author: ehaupt
Date: Tue Mar 23 16:57:37 UTC 2021
New revision: 569040
URL: https://svnweb.freebsd.org/changeset/ports/569040

Log:
  net-mgmt/nagstamon: Fix build with Python 3.8 and onward

  While here, pacify portclippy/portfmt.

  PR:		254502
  Submitted by:	kai
  Reference:	https://github.com/HenriWahl/Nagstamon/pull/705

Changes:
  head/net-mgmt/nagstamon/Makefile
  head/net-mgmt/nagstamon/files/
  head/net-mgmt/nagstamon/files/patch-setup.py
Comment 2 Emanuel Haupt freebsd_committer freebsd_triage 2021-03-23 16:59:02 UTC 
Committed, thanks @kai. I've created the following upstream pull request: https://github.com/HenriWahl/Nagstamon/pull/705