Bug 254564 - www/chromium: wrong dependency to libkrb5
Summary: www/chromium: wrong dependency to libkrb5
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-chromium (Nobody)
URL:
Keywords:
: 266162 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-03-25 23:10 UTC by Hiroo Ono
Modified: 2023-04-01 22:27 UTC (History)
6 users (show)

See Also:
bugzilla: maintainer-feedback? (chromium)


Attachments
dependency correction. (844 bytes, patch)
2021-03-25 23:10 UTC, Hiroo Ono
no flags Details | Diff
dependency correction (v2) (1.04 KB, patch)
2021-07-04 11:19 UTC, Ting-Wei Lan
no flags Details | Diff
Patch modified to use Mk/Uses/gssapi.mk (2.48 KB, patch)
2022-02-07 22:30 UTC, Hiroo Ono
no flags Details | Diff
Use GSSAPI macros to handle kerberos options. (2.87 KB, patch)
2023-04-01 22:27 UTC, David Marec
david: maintainer-approval? (chromium)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hiroo Ono 2021-03-25 23:10:48 UTC
Created attachment 223588 [details]
dependency correction.

www/chromium 88.0.4324.182 has wrong dependency to security/heimdal or security/krb5.
Comment 1 Tatsuki Makino 2021-04-09 05:43:55 UTC
To begin with, Mk/Uses/gssapi.mk exists for the selection of kerberos.
Comment 2 Ting-Wei Lan 2021-07-04 11:19:38 UTC
Created attachment 226214 [details]
dependency correction (v2)

Rebase attachment 223588 [details] to the latest commit of ports.
Comment 3 Hiroo Ono 2022-02-07 22:30:10 UTC
Created attachment 231621 [details]
Patch modified to use Mk/Uses/gssapi.mk

Reworked the patch to use Mk/Uses/gssapi.mk.
Comment 4 Graham Perrin freebsd_committer freebsd_triage 2022-11-20 00:23:02 UTC
*** Bug 266162 has been marked as a duplicate of this bug. ***
Comment 5 Dave Hayes 2023-03-27 03:26:45 UTC
This is still not really fixed. Look:

# grep krb ports/www/chromium/Makefile
MIT_DESC=		MIT Kerberos (security/krb5)
HEIMDAL_LIB_DEPENDS=	libkrb.so.26:security/heimdal
MIT_LIB_DEPENDS=	libkrb.so.3:security/krb5
.if ${PORT_OPTIONS:MHEIMDAL_BASE} && !exists(/usr/lib/libkrb5.so)

The Makefile even says libkrb5 down further than the actual DEPENDS line (admittedly that's in base).
Comment 6 Dave Hayes 2023-03-27 19:18:12 UTC
As of the 2023Q1 branch (with a recently committed chromium port skeleton) this is where my build stops:

[00:02:17] heimdal-7.1.0_1 uses a new database format which is incompatible
[00:02:17] with Heimdal in the base system and heimdal-1.5.3_6 or prior.
[00:02:17] 
[00:02:17] Please read 20161112 in /usr/ports/UPDATING carefully to upgrade
[00:02:17] your database.
[00:02:17] ===>   chromium-111.0.5563.110 depends on shared library: libkrb.so.26 - not found
[00:02:17] *** Error code 1

I can work around this by modifying the Makefile like this:

HEIMDAL_LIB_DEPENDS=	libkrb5.so.26:security/heimdal
Comment 7 David Marec 2023-04-01 22:27:06 UTC
Created attachment 241255 [details]
Use GSSAPI macros to handle kerberos options.

This is a patch based on the former one from @hiroo.ono+freebsd@gmail.com.

Poudriere 'testport' passed against the 4 kerberos choices, running 13.1-RELEASE on AMD64.

* ssl from base:
  *HEIMDAL: OK
  *HEIMDAL from base: OK
  *HEIMDAL mit: OK
  * No kerberos: OK

*libressl:
  *HEIMDAL: OK
  *HEIMDAL from base:KO, sanity check, this is expected.
  *HEIMDAL mit: OK
  *No kerberos: OK

*Openssl:
  *HEIMDAL: OK
  *HEIMDAL from base:KO, sanity check, this is expected.
  *HEIMDAL mit: OK
  *No kerberos: OK